Release Meeting: 01 Dec 2014

Details

1. Release blocker review

  • 12724 (Closed): Can't save topic settings or topic permissions MichaelDaum will close, task no longer applies.
  • 13077 (Closed): Configure crash "Not a HASH reference at ConfigurePlugin.pm line 160" GeorgeClark has been unable to figure out why this crashes. Regex typos bring down configure.
  • 13079 (Closed): Configure Bootstrap problems Catchall task for bootstrap issues. Leaving open to capture experiences.
  • 11658 (Confirmed): EDITTABLE does not work in multi-line syntax. Dropped to normal, not a blocker for 1.2, we don't ship EditTablePlugin with 1.2
  • 13125 (Closed): CGI::param called in list context from package Foswiki::Engine::CGI line 222, Being discussed on another channel.
  • 12475 (Closed): Move lib/CPAN/lib modules to a separate CpanContrib GeorgeClark will remove CPAN:CGI::Session from lib/CPAN/lib and close.
  • 12855 (Closed): Audit core DEPENDENCIES Catch-all for dependencies review. Found 2 more missing, and need follow-up.
  • 12993 (Closed): htmldoctype needs to change MichaelDaum closing.
  • 13040 (Closed): Foswiki 1.2 issues on Nginx GeorgeClark will address - email wizard issues under FCGI
  • 13062 (Closed): Multiple issues with Extensions installer on redesigned configure. GeorgeClark will review. CLI extension installation is noisy with warnings/errors.
  • 13063 (Closed): Configure needs to log changes Could use some help getting logger to function without a Foswiki SESSION object. But not urgent, could be closed as is.
  • 13066 (Closed): Checker issues due to 1.2 configure redesign. Catch-all for configure checkers, close once we go to beta.
  • 13068 (Closed): PlainFileStore / Foswiki bootstrap and migration considerations Plainfile migration - Needs review with CrawfordCurrie
  • 13078 (Closed): Core calls undocumented store method ALERT! This is an important blocker. There is a method missing from Plainfile store.
  • 13080 (Closed): Configuration setting errors ALERT! seeing some config file issues, growing regexes, escaped/quoted strings.
  • 13096 (Closed): CommentPlugin generates "Invalid validation code" REST error when trying to add comment in Firefox ALERT! CommentPlugin javascript crashes on some browsers including Firefox and Crhomium on linux.
  • 13100 (Closed): bulk_copy.pl needs thorough review & testing for 1.2 Could go to beta with this open. Store converter needs thorough testing in beta.
  • 13126 (Closed): MailerContrib fails to generate diff correctly on view restricted webs Probably not really a blocker.
  • 12477 (Closed): Spurious entries being added to .changes This exists in 1.1, so it's not horrible, but a store issue breaks email notificatinos.
  • 12888 (Closed): Unit tests are failing No current failing tests - left open as a catchall
  • 13030 (Closed): deprecate jquery.tmpl and add jsrender MichaelDaum in progress.
  • 13105 (Closed): ease SEARCH apps in System web Also MichaelDaums - probably should not block a beta release.
  • 13124 (Closed): Documentation updates to support Apache 2.4 Probably a documentation issue.

Overall it looks like we are getting very close to being able to build an alpha or beta. Many of these tasks could be ignored for a first beta.

The other big blocker for beta is we don't have a translation framework running. we need someone to help with python / wsgi / freebsd to get the Weblate product installed.

Next meeting - - Monday December 15, 1300Z

IRC Log

 
(08:05:57 AM) gac410: Hm... good morning ,  light turnout so far.   Want to give it some more time?
(08:21:26 AM) gac410: Is it worth starting with just the few of us?  
(08:25:46 AM) ModAcOst entered the room.
(08:26:07 AM) ModAcOst: We start earlier now?
(08:26:45 AM) gac410: 1300Z    For some of us that's an hour earlier due to end of Daylight Savings
(08:27:11 AM) ModAcOst: Ah, ok
(08:27:21 AM) ModAcOst: My apologies for beeing late then
(08:27:42 AM) gac410: We can slip to 1400Z if everyone wants.   I'm barely awake      Nothing started yet.   I think everyone has the same idea.
(08:28:26 AM) gac410: I figured I could start a task review.     http://foswiki.org/Tasks/MinorReleaseBlocker
(08:28:51 AM) gac410: There were two tasks that you (ModAcOst) had volunteered to work on.     Any idea if you'll get to them?
(08:29:11 AM) gac410: Hard coded attachment tables,  and unit tests for page cache?
(08:29:18 AM) ModAcOst: Yea, sorry, didn't get around to doing them.
(08:29:35 AM) ModAcOst: I'll do at least one until next week, promised
(08:29:46 AM) gac410: okay.  thanks.
(08:30:39 AM) gac410: MichaelDaum:   http://foswiki.org/Tasks/Item12724    seems to be maybe a missing dependency in NatEditPlugin ... I suspect that this is old and doesn't apply to 1.2 ?
(08:33:28 AM) MichaelDaum: Hi George. Looking at https://github.com/foswiki/distro/blob/master/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/DEPENDENCIES ... dependencies seem to be asserted correctly
(08:34:20 AM) gac410: yeah I'm guessing it was old ...   lets close it.
(08:34:36 AM) MichaelDaum: let me do it
(08:34:45 AM) gac410: okay
(08:35:32 AM) MichaelDaum: done
(08:36:09 AM) gac410: A lot of the Configure tasks really need CDot.    I'm utterly lost by http://foswiki.org/Tasks/Item13077      You can trigger it anytime by making a typo in a regex field so that the regex compile fails.
(08:36:27 AM) gac410: But the underlying issue seems to be masked.   I can't find where it fails.
(08:37:57 AM) gac410: http://foswiki.org/Tasks/Item13079 is a catch-all.   Left open for people to report bootstrap issues,   we can close it at release.  It currently has no outstanding issues.
(08:39:03 AM) gac410: http://foswiki.org/Tasks/Item11658   can drop to normal.   EditTablePlugin is not part of 1.2.
(08:40:39 AM) MichaelDaum: http://foswiki.org/Tasks/Item13125 ... how do we deal with it during the release? 
(08:41:13 AM) MichaelDaum: I am not really sure I know what the new warning messages are ... but provided a patch to quiet it ;)
(08:42:16 AM) gac410: I reopened http://foswiki.org/Tasks/Item12475      With CDot's  configure rewrite we can remove the last shipping CPAN module ... Configure no longer needs CGI::Session
(08:42:29 AM) MichaelDaum: yay
[redacted discussion of Item13125]
(08:49:32 AM) gac410: http://foswiki.org/Tasks/Item12855     More issues.   I installed on debian testing last night and found 2 missing deps from our documentation   File::Copy::Recursive and JSON     Fixed SystemRequirements for debian, but didn't do the other OS's
(08:50:36 AM) gac410: http://foswiki.org/Tasks/Item12993     Michael,  that's a skin change for htmldoctype ...  could you handle that one?
(08:51:42 AM) gac410: http://foswiki.org/Tasks/Item13040   nginx issues.    I need to fiddle some more with the email  configuration wizard.   It's not happy under fcgid.  
(08:52:37 AM) gac410: http://foswiki.org/Tasks/Item13062   Probably one I need to work on ,  or CDot 
(08:53:47 AM) MichaelDaum: http://seclists.org/vulnwatch/2006/q4/6 is the security report to consider while checking our code 
(08:54:06 AM) gac410: http://foswiki.org/Tasks/Item13063   Configure logging changes.    Mostly fixed.  But I left it open because I'd really like to create a logger instance from the shell when no Foswiki SESSION exists,  but I failed on my attempt.
(08:54:12 AM) MichaelDaum: ... for the cgi param thing
(08:54:46 AM) gac410: Thanks MichaelDaum    Maybe a review of that and we can decide just to add the error suppress.  
(08:55:38 AM) gac410: http://foswiki.org/Tasks/Item13066   is a catch-all for configure checker issues discovered during 1.2 testing
[redacted]
(08:57:33 AM) gac410: http://foswiki.org/Tasks/Item13068    plainfile migration.    I think that could be closed, but leaving it up to CDot
[redacted]
(08:58:58 AM) gac410: http://foswiki.org/Tasks/Item13078 is a huge issue in plainfile.    There is a method missing from that store.   Probably needs CDot  :(    
(08:59:22 AM) MichaelDaum: gawd Ive forgotten lunch
(08:59:48 AM) gac410: :)   And I've forgotten breakfast.     Don't remind me  
(09:00:08 AM) MichaelDaum: lets eat sumthin. back in a few minutes.
(09:00:31 AM) gac410: http://foswiki.org/Tasks/Item13080   is a big issue for the email wizard,  and regexes grow wherever edited.      
(09:00:47 AM) gac410: Yup.   take 5. ... bio break
(09:09:29 AM) gac410: http://foswiki.org/Tasks/Item13096   Comment plugin strikeone issues on trunk    That makes using tasks web on trunk useless for me.   Claims to be a firefox issue, but I've not gotten chromium to work either.
(09:11:39 AM) gac410: http://foswiki.org/Tasks/Item13100    We could go to beta with this open.   Just notes we need to thoroughly test the store conversion code.
(09:12:39 AM) gac410: http://foswiki.org/Tasks/Item13110  is JQTablePlugin ...  Not a 1.2 extension,  (Though I'd like to to be .. to deal with the "bots" that are killing us sorting tables)
(09:13:49 AM) gac410: http://foswiki.org/Tasks/Item13126   is new.  MailerContrib doesn't generate diff correctly on view restricted webs.   Annoying but I'm not sure it's really a blocker
(09:15:23 AM) gac410: http://foswiki.org/Tasks/Item12477   is a store issue.  The changes logger changes made in 1.1.x were not well thought out.  eachChangeSince gets it wrong if an attachment is updated.  Really needs some redesign.   I was going to work on it but have not really figured out what to do yet. :(
(09:15:50 AM) gac410: http://foswiki.org/Tasks/Item12888   .. catch all for unit test failures.  Nothing pending
(09:17:16 AM) gac410: http://foswiki.org/Tasks/Item13030 is Michale's    not sure if it is complete enough yet to not be a blocker
(09:18:15 AM) gac410: http://foswiki.org/Tasks/Item13105 also Michaels,     But it probably doesn't block a beta
(09:19:37 AM) gac410: And last of the blockers  http://foswiki.org/Tasks/Item13124  Apache 2.4 docs updates.   Need to add mod_access_compat note, suggested by jast.  
(09:23:14 AM) gac410: So mostly I think we are getting very close to a beta, or at least an alpha.   The real blockers:  http://foswiki.org/Tasks/Item13078   and maybe http://foswiki.org/Tasks/Item13096    
(09:24:25 AM) gac410: Oh... and without Weblate or Pootle,  we have no way to do translations.  That is really needed too.   Needs someone to help maintain the server who knows python / wsgi and freebsd
(09:32:45 AM) MichaelDaum: Item13105 just has a few left. the fixes I checked in definitely help keeping a foswiki up and running not wasting too much server resources on crawlers anymore
(09:33:56 AM) gac410: y.   That and changing to JQTablePlugin     and I killed the Yahoo! slurp bot in the apache config,    And bumped the monit system cpu threshold from 30 to 50 to 80%   to quiet it down  :)
(09:41:04 AM) gac410: With that list,  any thoughts on moving forward with an alpha?   Really need CDot on 13078   Or we defer  PlainFile for now.   The CommentPlugin  13096 ... not sure what the issue there is.
(09:41:23 AM) gac410: Can anyone comment on tasks using trunk.    I'm completely blocked
(09:51:58 AM) gac410: MichaelDaum:  One thing I thought of while reviewing apache configurations.    jsonrpc   script.   For sites using Apache auth,   that should probably be a script that requires authentication
(09:52:16 AM) MichaelDaum: no
(09:52:28 AM) MichaelDaum: it checks authentication on application level
(09:52:28 AM) gac410: No???    It can update the configuration.   
(09:54:02 AM) gac410: I notice it returns a 500 btw  and not a valid 4xx status,  for ex.  going a GET to jsonrpc
(09:54:57 AM) gac410: 405 is status for "Method not allowed" 
(09:55:24 AM) MichaelDaum: 500 is the default http error for jsonrpc errors when using jsonrpc
(09:55:37 AM) MichaelDaum: so the real error is encoded inthe json being returned
(09:55:46 AM) MichaelDaum: 500 means: general server error
(09:56:17 AM) MichaelDaum: reason is: there are simply not enough http error codes for all kinds of error states of an application
(09:56:34 AM) MichaelDaum: so 500 for http, json rpc error code inside the json obj being returned.
(09:56:53 AM) gac410: okay
(09:57:22 AM) MichaelDaum: I am now checking the jsonrpc handlers of ConfigurePlugin whether they check access
(09:57:40 AM) gac410: I'm pretty sure they do.
(09:58:27 AM) MichaelDaum: there is an isAnAdmin
(09:58:34 AM) gac410: I added the checks against ConfigureFilter.      It used to just check isAdmin.       I didn't want site admins to be able to also edit the config.
(09:59:04 AM) MichaelDaum: bootstrap can be done as a non-admin
(09:59:10 AM) MichaelDaum: of course
(09:59:18 AM) MichaelDaum: anything else has to be an admin
(09:59:42 AM) gac410: yes.    It has to. ... though first thing it does is create an admin session,  so after first bootstrap,  user should have an auth cookie for admin.
(09:59:45 AM) MichaelDaum: though you are right about the error code
(10:00:14 AM) MichaelDaum: it die()s unless isAnAdmin ... however it should throw a jsonrpc exception with the correct code in it
(10:02:15 AM) gac410: okay. 
(10:02:27 AM) MichaelDaum: but thats nit picking
(10:03:07 AM) gac410: We should probably document that jsonrpc does not need to be protected ... comments in apache config examples,  and in the AuthScripts field in configure. 
(10:03:25 AM) gac410: Since I'm diddling with the configurations, I'll add that.
(10:04:23 AM) gac410: Anything more to discuss?    We are at 2 hour mark. 
(10:05:27 AM) gac410: Please let me know what you think about the "Real blockers"   ie   stuff blocking a alpha build for general testing.  
(10:08:30 AM) gac410: My bigger concern,  unrelated to tasks, is lack of translations.  We really need some server help for that.   gmc was going to install python / wsgi / weblate   back in July.. but seems to have fallen through the cracks. :(
(10:09:58 AM) gac410: Okay.... declaring this release meeting closed.   I'll work on minutes  a few hours from now.   NEXT MEETING  Monday December 15,  1300Z   
(10:16:54 AM) MichaelDaum: thanks for this floating release meeting
(10:17:06 AM) MichaelDaum: lite weight and productive
(10:20:59 AM) gac410: Yes indeed.  yw ... It gives me the good feeling that we are actually making progress.    Now to get some more participants :)     Maybe we need emails to foswiki_discuss,  or even a one-time to foswiki_announce
(10:21:40 AM) gac410: It also is heartening to see submissions coming in via github.   Not a lot, but still   better than was happening with svn
(10:22:29 AM) gac410: And  yesterday, someone via github installed master following our docs,  had good feedback and got a running 1.2 system.  
(10:22:50 AM) gac410: Anyway ... I'm off to the store.   laters
(11:37:38 AM) ModAcOst left the room (quit: Quit: Konversation terminated!).
(12:38:32 PM) MichaelDaum left the room (quit: ).

Topic revision: r2 - 03 Dec 2014, JulianLevens
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy