Release Meeting: 13 Nov 2017

Details

General status.

1. Task review

2. Development Discussion

Discussed Logout URL processing The LOGOUTURL macro does not appear to be used. Pattern and Nat skin both build the URL directly in the templates. We could probably remove the macro.

3. Next release

Patch release 2.1.5

  • Release from: Release02x01
  • Beta start:
  • Release target:

Feature release 2.2.0

  • Feature Freeze: 01 Dec 2017
  • Release from: master
  • Beta start: 15 Dec 2017
  • Release target: 15 Jan 2018

4. Community Events

  • Joint "Wiki-Based Projects" booth at FOSDEM 2018 together with TikiWiki, XWiki and DocuWiki

Next meeting - - Monday 27 Nov 2017 1300Z — ReleaseMeeting02x02_20171127

Please review and be prepared to discuss FeatureProposals and ReleasePlan

IRC Log

(08:00:50 AM) zak256 entered the room.
(08:01:28 AM) gac410: Hi everyone. 1300Z an hour earlier for everyone who went off of daylight saving time
(08:04:01 AM) MichaelDaum: Hi George
(08:04:44 AM) gac410: Hi Michael
(08:05:48 AM) gac410: Okay all lets get started.
(08:06:14 AM) gac410: Urgent tasks ... There has not been much activity, so not much to report there.
(08:07:28 AM) MichaelDaum: times are busy behind the scene
(08:07:51 AM) gac410: Proposals. Not much activity. My proposal to replace ICON with JQICON has "timed out" and approved by default. No discussion.
(08:08:03 AM) MichaelDaum: okay fine
(08:08:20 AM) zak256: :-) fine
(08:08:41 AM) ***gac410 hates when we proceed by default. Seems like someone always discovers an issue after it's implemented :D
(08:08:54 AM) gac410: Anything else to report?
(08:08:57 AM) MichaelDaum: heh
(08:09:25 AM) MichaelDaum: I just had a block posting about fosdem 2018 ... yet nobody seems to be replying. well, so it is.
(08:10:15 AM) MichaelDaum: Bram was preparing another one on some plugin work of his. yet not set to "published"
(08:10:31 AM) gac410: I do have a question. I was working on a secure site that will have a public "landing" page. But when an auth user logs out, they get an immediate prompt to log in. We don't have any setting to "redirect to a public page" on logout
(08:11:06 AM) MichaelDaum: "good bye and thank you for the fish"
(08:11:30 AM) gac410: exactly. HomePagePlgin doesn't do it either.
(08:11:47 AM) MichaelDaum: I regularly simply uninstall homepage yadda
(08:11:50 AM) gac410: LoginManager::redirectToLoggedOutUrl "sounds" like it would, but it always goes to the same page.
(08:13:17 AM) gac410: Seems like a "{Login}{RedirectOnLogout} = 'Web.Topic' would be a really simple fix
(08:13:59 AM) gac410: I suppose even on-liners need a feature request. :P
(08:14:44 AM) MichaelDaum: maybe Web.Topic isn't enuf, in case you'd require more control over the url
(08:15:18 AM) gac410: Anyway. I was wondering if we should start sending emails to foswiki-discuss "New proposal needs comment" etc.
(08:15:52 AM) MichaelDaum: good idea
(08:15:54 AM) gac410: y, good point. Another is maybe it ought to to be a hook rather than a field.
(08:16:19 AM) MichaelDaum: or we make the url param redirectto work on logouts
(08:16:40 AM) MichaelDaum: worth a test actually
(08:17:01 AM) gac410: Ah.. Change the logout URL to include a redirect= on it.
(08:17:35 AM) MichaelDaum: {view}/web/topic?logout=1&redirectto=web.topic should actually be covered by the specs though LoggdOutUrl might override it for the worth .... which would be more of a bug
(08:18:22 AM) MichaelDaum: looking at the code it doesnt seem to pay attention to any redirect already being performed otherwise
(08:19:14 AM) gac410: y, it doesn't actually do anything other than redirect to the current location. There seems to be no such thing as a "logged out URL"
(08:19:43 AM) MichaelDaum: then chances are you've found a bug: redirectto ignored when logging out
(08:20:10 AM) gac410: So maybe 2 changes need experimentation. 1) Honor redirectto and 2) Allow an override / default on logout.
(08:21:54 AM) gac410: And maybe a logoutHandler (bookend for the initializeUserHandler which runs during login.)
(08:22:19 AM) MichaelDaum: LoginManager.pm registers a macro %LOGOUTURL
(08:23:15 AM) MichaelDaum: we could extend it to allow %LOGOUTURL{param="..." param="..."}%
(08:23:34 AM) MichaelDaum: and then have a %LOGOUTURL{redirectto="..."}%
(08:24:07 AM) gac410: iirc there is an old task lurking over LOGOUTURL
(08:24:10 AM) MichaelDaum: for a manual override of a {DefaultLogoutRedirect} = 'some url'
(08:24:34 AM) gac410: y. I guess this is worth a bit more investigation, and a feature proposal.
(08:24:53 AM) MichaelDaum: https://foswiki.org/Tasks/Item1022
(08:26:17 AM) MichaelDaum: the checkin to it doesn't actually fix the issue, it seems
(08:27:09 AM) gac410: No... it works.
(08:27:13 AM) MichaelDaum: and we are missing %LOGINURL
(08:27:42 AM) MichaelDaum: ah we have
(08:28:11 AM) gac410: If you change the path Your current page is "Private/WebHome and logout URL iss "Public/WebHome?logout=1 that works too.
(08:28:33 AM) gac410: So changing the logout URL to point to a publilc page would fix it I think.
(08:28:42 AM) MichaelDaum: slap. of course.
(08:28:58 AM) gac410: No code needed :D
(08:31:28 AM) gac410: btw, I went with natskin for a new site I'm working on. It would be really helpful if in all the plugin descriptions, it included NatSkin Ecosystem or something unique, so that search for extensions could find all the extensions helpful for NatSkin
(08:32:17 AM) MichaelDaum: you mean the content of DEPENDENCIES?
(08:32:56 AM) MichaelDaum: or some sort of banner "worx best on a nat skin"
(08:34:11 AM) gac410: Something so that configure / search for extensions can show a list of the extensions used with NatSkin, Not just dependencies.
(08:34:49 AM) gac410: It can search for a partial name, or partial description. So something unique would have them pop out in the list.
(08:36:26 AM) MichaelDaum: which plugin have you missed?
(08:37:33 AM) gac410: I didn't miss any. But it was painful trying to find them by searching for name, while comparing the list of plugins installed on blog.foswiki.org ;D
(08:38:08 AM) gac410: And "show all extensions" is a huge list. I'm just Whining never mind :D
(08:38:34 AM) gac410: BTW Set LOGOUTURL = ...... in SitePreferences seems to be ignored. unless I'm doing something stupid.
(08:39:49 AM) MichaelDaum: yea. it is a macro.
(08:40:59 AM) gac410: Damn. WebLeftBarLogin doe not actually use the LOGOUTURL
(08:41:13 AM) gac410: wtf
(08:42:03 AM) MichaelDaum: alright. didn't have lunch yet.
(08:42:09 AM) gac410: ;)
(08:42:14 AM) ***gac410 didn't have breakfast
(08:42:17 AM) MichaelDaum: anything else we can't move to #foswiki ;)
(08:42:24 AM) MichaelDaum: ?
(08:42:41 AM) gac410: I don't have anything else.
(08:42:56 AM) gac410: Getting more participation woudl be really nice.
(08:43:13 AM) MichaelDaum: sure sure.
(08:44:04 AM) MichaelDaum: alright. will be back in an hour or so ... after hunting down lunch.
(08:44:21 AM) gac410: okay. cu later. I may have to run out in a bit.
(08:44:34 AM) MichaelDaum: cu
(08:44:37 AM) MichaelDaum is now known as MichaelDaum_
(09:03:40 AM) zak256 left the room.
(09:22:54 AM) MichaelDaum_ is now known as MichaelDaum
(11:35:08 AM) MichaelDaum left the room (quit: Quit: quit).
(01:24:09 PM) The account has disconnected and you are no longer in this chat. You will automatically rejoin the chat when the account reconnects.

Topic revision: r2 - 08 Dec 2017, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy