You are here: Foswiki>Tasks Web>Item10139 (08 Sep 2011, SvenDowideit)Edit Attach

Item10139: Startup warning for uninitialized value $pidfile in foswiki.fcgi

pencil
Priority: Low
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: FastCGIEngineContrib
Branches:
Reported By: CharlesAdicke
Waiting For:
Last Change By: SvenDowideit
There are now two issues with proposed patches for this problem (see Tasks.Item9957). Any chance someone can test and commit something?

-- AaronFuleki - 26 Aug 2011
 

Due the usage of an uninitialized value of $pidfile during startup of the FCGI service the following warning shows up in the logs:
==> /var/log/apache2/error.log <==
Use of uninitialized value $pidfile in pattern match (m//) at
foswiki.fcgi line 62.

The fix is trivial:

--- foswiki.fcgi.org   2010-12-07 16:30:50.000000000 +0900
+++ foswiki.fcgi-fix   2010-12-07 17:00:17.000000000 +0900
@@ -59,7 +59,8 @@
 pod2usage(1) if $help;
 
 # untaint
-$pidfile =~ /^(.*)$/ and $pidfile = $1;
+$pidfile =~ /^(.*)$/ and $pidfile = $1
+   if $pidfile;
 
 @ARGV = @argv;
 undef @argv;

there's been a fix for this commited since 2010

so i've uploaded a version - looks like too many people run from svn.

-- SvenDowideit - 08 Sep 2011

ItemTemplate edit

Summary Startup warning for uninitialized value $pidfile in foswiki.fcgi
ReportedBy CharlesAdicke
Codebase 1.1.2
SVN Range
AppliesTo Extension
Component FastCGIEngineContrib
Priority Low
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
Topic revision: r3 - 08 Sep 2011, SvenDowideit
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy