Priority: Urgent
Current State: No Action Required
Released In: n/a
Target Release: patch
Applies To: Engine
Component:
Branches:
If I update a formfield in the topic text file, that change is not reflected on the rendered page (but a change in the topic text is). That means that the old value is shown in everything that queries that form field.
- This happens without caching enabled.
- This happens also when viewing the page in a different browser that does not have a cache.
- It fixes itself when I remove the .txt,v file. Meaning that the form field value is retrieved from the .txt,v unless that file does not exist.
This might be an optimization, but also a serious bug.
--
ArthurClemens - 20 Feb 2011
See also:
Item9482 and
Item9487
--
PaulHarvey - 20 Feb 2011
The problem is the way we treat the editable file as a revision; but an uncontrolled revision. If the head of the rev tree is version X, then the checked out copy is either version X, or version X+1, dependning on whether it was manually edited or not. Trouble is, if it's X+1 and someone deletes the .txt, you've lost history. But if it's X, you can't check in a second copy of the same rev.
The code in 1.1.2 is more correct, but this is a case where we want it to be a bit less correct. "Just" needs careful study of the VC:: code to make it work (and testcases of course)
--
CrawfordCurrie - 28 Feb 2011
I cannot understand how to reproduce this problem.
Is this in Release01x01 branch? And what do I need to do to see the problem.
I can hack a .txt file changing a form value and it is shown just fine.
--
KennethLavrsen - 28 Feb 2011
Confirmed by creating a new
FrequentlyAskedQuestions topic, then doing a save & forenewrev, then modifying the .txt manually.
The
FAQViewTemplate uses
VarFORMFIELD which shows the ,v version. If you view the new FAQ topic using
?template=view
, you get the "correct", manually-edited .txt version.
--
PaulHarvey - 01 Mar 2011
It happens with any topic with a form that has a ,v version file. If you edit the .txt file, the displayed form data will still come from the ,v file.
--
ArthurClemens - 02 Mar 2011
I cannot see that this happens. There must be a special circumstance that triggers this. Is this in Release branch you see this?
--
KennethLavrsen - 05 Mar 2011
It happens on Release branch and on trunk.
To reproduce:
- Have a form
- Create or edit a topic: add form to topic, add form values, save
- In the terminal or text editor, change one of the values in META data
- View in browser
--
ArthurClemens - 05 Mar 2011
That is how I understood it.
That is what I tried again just now.
I do not see this error.
Can anyone else confirm this error? Otherwise it must be something related to a CPAN lib version or perl version.
--
KennethLavrsen - 06 Mar 2011
Yikes. I cannot reproduce now... weird :/
--
PaulHarvey - 06 Mar 2011
I can't reproduce it on trunk.foswiki.org either.
Might be my system, or Macs.
Setting to "no action" until I hit this again.
--
ArthurClemens - 06 Mar 2011