Item10398: Item10344 work introduces some breakage

The good news is that I think what you've done here seems to make things faster, although I have yet to stabilize my testing environment to confirm for sure.

Here is a backtrace I was getting after these changes (which do not happen if I revert to distro:45794d0ffd92 )

         Could not perform search. Error was: Assertion failed!
 at /usr/local/src/git.trin.org.au/core/lib/Assert.pm line 80
   Assert::ASSERT('') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/MetaCache.pm line 186
   Foswiki::MetaCache::get('Foswiki::MetaCache=HASH(0x9b895a0)', 'Trash', 'MainBobTest') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Store/QueryAlgorithms/BruteForce.pm line 212
   Foswiki::Store::QueryAlgorithms::BruteForce::_webQuery('Foswiki::Query::Node=HASH(0x9c845e0)', 'Main', undef, 'Foswiki=HASH(0x96be008)', 'HASH(0x9b45708)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Store/QueryAlgorithms/BruteForce.pm line 76
   Foswiki::Store::QueryAlgorithms::BruteForce::query('Foswiki::Query::Node=HASH(0x9c845e0)', undef, 'Foswiki=HASH(0x96be008)', 'HASH(0x9b45708)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Store/VC/Store.pm line 508
   Foswiki::Store::VC::Store::query('Foswiki::Store::RcsWrap=HASH(0x96eabd0)', 'Foswiki::Query::Node=HASH(0x9c845e0)', undef, 'Foswiki=HASH(0x96be008)', 'HASH(0x9b45708)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Meta.pm line 874
   Foswiki::Meta::query('Foswiki::Query::Node=HASH(0x9c845e0)', undef, 'HASH(0x9b45708)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Search.pm line 350
   Foswiki::Search::searchWeb('Foswiki::Search=HASH(0x98ef078)', 'search', 'name=\'WebPreferences\'', 'basetopic', 'MongoDBLoadWebs', '_RAW', '\x{a}  "name=\'WebPreferences\'"\x{a}  type="query"\x{a}  web="all"\x{a}  rec...', 'web', 'all', ...) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/SEARCH.pm line 32
   Foswiki::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0x9c91338)', 'HASH(0x9e4ba78)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/SEARCH.pm line 41
   Foswiki::SEARCH('Foswiki=HASH(0x96be008)', 'Foswiki::Attrs=HASH(0x9e39830)', 'Foswiki::Meta=HASH(0x9bc65d0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3030
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0x96be008)', 'SEARCH', '\x{a}  "name=\'WebPreferences\'"\x{a}  type="query"\x{a}  web="all"\x{a}  rec...', 'Foswiki::Meta=HASH(0x9bc65d0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2911
   Foswiki::_processMacros('Foswiki=HASH(0x96be008)', '\x{a}---++ <a href="http://lifebook/bin/System/MongoDBPlugin">MongoDBPlugin</a> load webs utility\x{a}\x{a}&lt;a id="mongoloadall" ...', 'CODE(0x93afff0)', 'Foswiki::Meta=HASH(0x9bc65d0)', 16) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2708
   Foswiki::innerExpandMacros('Foswiki=HASH(0x96be008)', 'SCALAR(0x9c367c0)', 'Foswiki::Meta=HASH(0x9bc65d0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3207
   Foswiki::expandMacros('Foswiki=HASH(0x96be008)', '\x{a}---++ <a href="http://lifebook/bin/System/MongoDBPlugin">MongoDBPlugin</a> load webs utility\x{a}\x{a}&lt;a id="mongoloadall" ...', 'Foswiki::Meta=HASH(0x9bc65d0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Meta.pm line 3181
   Foswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x9bc65d0)', '\x{a}---++ <a href="http://lifebook/bin/System/MongoDBPlugin">MongoDBPlugin</a> load webs utility\x{a}\x{a}&lt;a id="mongoloadall" ...') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI/View.pm line 406
   Foswiki::UI::View::_prepare('\x{a}---++ <a href="http://lifebook/bin/System/MongoDBPlugin">MongoDBPlugin</a> load webs utility\x{a}\x{a}&lt;a id="mongoloadall" ...', 'Foswiki::Meta=HASH(0x9bc65d0)', 0) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI/View.pm line 386
   Foswiki::UI::View::view('Foswiki=HASH(0x96be008)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI.pm line 316
   Foswiki::UI::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0x924c3d0)', 'HASH(0x96bdd28)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI.pm line 435
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x9342818)', 'CODE(0x969d590)', 'command_line', 1, 'view', 1) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI.pm line 277
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x9342818)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Engine/CLI.pm line 53
   Foswiki::Engine::CLI::run('Foswiki::Engine::CLI=HASH(0x93a4048)') called at bin/view line 29.

The culprit was a mis-named topic.txt, core/data/Main/Trash.MainBobTest.txt

The search was

%SEARCH{
  "name='WebPreferences'"
  type="query"
  web="all"
  recurse="on"
  nonoise="on"
}%

See Item10344

-- PaulHarvey - 23 Feb 2011

Also, it seems that

%FORMFIELD{"SomeField" topic="SomeMissingTopic"}%

is broken too:

Assertion failed!
 at /usr/local/src/git.trin.org.au/core/lib/Assert.pm line 80
   Assert::ASSERT('') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Meta.pm line 969
   Foswiki::Meta::loadVersion('Foswiki::Meta=HASH(0xef6bb00)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Meta.pm line 1766
   Foswiki::Meta::haveAccess('Foswiki::Meta=HASH(0xef6bb00)', 'VIEW') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Render.pm line 931
   Foswiki::Render::renderFORMFIELD('Foswiki::Render=HASH(0xee9e040)', 'Foswiki::Attrs=HASH(0xfe57fd0)', 'Foswiki::Meta=HASH(0x101072f0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/FORMFIELD.pm line 21
   Foswiki::FORMFIELD('Foswiki=HASH(0xf12c8d0)', 'Foswiki::Attrs=HASH(0xfe57fd0)', 'Foswiki::Meta=HASH(0x1011c980)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3031
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xf12c8d0)', 'FORMFIELD', '"LabelTerm" topic="TaxonProfile/Definitions.Genome_Sequences_...', 'Foswiki::Meta=HASH(0x1011c980)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2912
   Foswiki::_processMacros('Foswiki=HASH(0xf12c8d0)', '%<nop>FORMFIELD{\x{a}   "%FORMFIELD{"LabelTerm" topic="%profileto...', 'CODE(0x95c73a8)', 'Foswiki::Meta=HASH(0x1011c980)', 16) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2709
   Foswiki::innerExpandMacros('Foswiki=HASH(0xf12c8d0)', 'SCALAR(0x1003b238)', 'Foswiki::Meta=HASH(0x1011c980)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/INCLUDE.pm line 291
   Foswiki::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0x101333b8)', 'HASH(0xf1404f0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/INCLUDE.pm line 338
   Foswiki::INCLUDE('Foswiki=HASH(0xf12c8d0)', 'Foswiki::Attrs=HASH(0x10143718)', 'Foswiki::Meta=HASH(0x100e2410)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3031
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xf12c8d0)', 'INCLUDE', '\x{a}      "TaxonCreator"\x{a}      section="lookuptaxonlabeltermlabe...', 'Foswiki::Meta=HASH(0x100e2410)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2912
   Foswiki::_processMacros('Foswiki=HASH(0xf12c8d0)', '| *Topic* | *User* | *Modified* |\x{a}| [[Acacia/DnaData.Gene1974...', 'CODE(0x95c73a8)', 'Foswiki::Meta=HASH(0x100e2410)', 15) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2930
   Foswiki::_processMacros('Foswiki=HASH(0xf12c8d0)', '---++ All Taxa\x{a}\x{a}[[%BASEWEB%.TaxonCreator][ %ICON{"newtopic"}%...', 'CODE(0x95c73a8)', 'Foswiki::Meta=HASH(0x100e2410)', 16) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2709
   Foswiki::innerExpandMacros('Foswiki=HASH(0xf12c8d0)', 'SCALAR(0xf0d6fb8)', 'Foswiki::Meta=HASH(0x100e2410)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/INCLUDE.pm line 291
   Foswiki::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0x100a8c70)', 'HASH(0xddf4520)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/INCLUDE.pm line 338
   Foswiki::INCLUDE('Foswiki=HASH(0xf12c8d0)', 'Foswiki::Attrs=HASH(0x1011ca10)', 'Foswiki::Meta=HASH(0xdcdf228)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3031
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xf12c8d0)', 'INCLUDE', '"TaxonProfile/Builder.Taxa" NAMESPACE="Genome" DEFAULTPROFILE...', 'Foswiki::Meta=HASH(0xdcdf228)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2912
   Foswiki::_processMacros('Foswiki=HASH(0xf12c8d0)', '%INCLUDE{"%BUILDERWEB%.%TOPIC%" NAMESPACE="Genome" DEFAULTPRO...', 'CODE(0x95c73a8)', 'Foswiki::Meta=HASH(0xdcdf228)', 16) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2709
   Foswiki::innerExpandMacros('Foswiki=HASH(0xf12c8d0)', 'SCALAR(0xab09418)', 'Foswiki::Meta=HASH(0xdcdf228)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/INCLUDE.pm line 291
   Foswiki::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0xe483388)', 'HASH(0x1010fae8)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Macros/INCLUDE.pm line 338
   Foswiki::INCLUDE('Foswiki=HASH(0xf12c8d0)', 'Foswiki::Attrs=HASH(0xedadcb8)', 'Foswiki::Meta=HASH(0x100d1b70)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3031
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xf12c8d0)', 'INCLUDE', '"Taxa"', 'Foswiki::Meta=HASH(0x100d1b70)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2912
   Foswiki::_processMacros('Foswiki=HASH(0xf12c8d0)', '---+!! Foo\x{a}\x{a}<img align="right" alt="lorum  shark" height="238...', 'CODE(0x95c73a8)', 'Foswiki::Meta=HASH(0x100d1b70)', 16) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 2709
   Foswiki::innerExpandMacros('Foswiki=HASH(0xf12c8d0)', 'SCALAR(0xa7338b8)', 'Foswiki::Meta=HASH(0x100d1b70)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki.pm line 3208
   Foswiki::expandMacros('Foswiki=HASH(0xf12c8d0)', '---+!! Foo\x{a}\x{a}<img align="right" alt="lorum  shark" height="238...', 'Foswiki::Meta=HASH(0x100d1b70)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Meta.pm line 3138
   Foswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x100d1b70)', '---+!! Foo\x{a}\x{a}<img align="right" alt="lorum  shark" height="238...') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI/View.pm line 406
   Foswiki::UI::View::_prepare('---+!! Foo\x{a}\x{a}<img align="right" alt="lorum  shark" height="238...', 'Foswiki::Meta=HASH(0x100d1b70)', 0) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI/View.pm line 386
   Foswiki::UI::View::view('Foswiki=HASH(0xf12c8d0)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI.pm line 316
   Foswiki::UI::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0xf035f58)', 'HASH(0xfa698d8)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI.pm line 435
   Foswiki::UI::_execute('Foswiki::Request=HASH(0xe8079b8)', 'CODE(0x9610170)', 'view', 1) called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/UI.pm line 277
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0xe8079b8)') called at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Engine/FastCGI.pm line 137
   Foswiki::Engine::FastCGI::run('Foswiki::Engine::FastCGI=HASH(0x901d170)', undef, 'HASH(0x8f34200)') called at /usr/local/src/git.trin.org.au/core/bin/foswiki.fcgi line 69.

-- PaulHarvey - 23 Feb 2011

core/data/Main/Trash.MainBobTest.txt

cooool - fixed that one, but will need help making a unit test for the other.

on 1.0 you can't view the dot named topic - so i've just made it not return in the SEARCH result.

-- SvenDowideit - 23 Feb 2011

I up'd to urgent because SiteChanges is broken on trunk

Also: Use of uninitialized value in substitution iterator at /usr/local/src/git.trin.org.au/core/lib/Foswiki/Render.pm line 1660. when I edit some topics... haven't found the pattern yet (MongoDBPlugin disabled, i.e. brute/forking)

-- PaulHarvey - 23 Feb 2011

Maybe it's only happening on new-topics... Eg. this is producing the error for me right now:

http://ogg.lan/bin/edit/TaxonProfile/Definitions/?Label=Sample&topic=Genome_Sample_Form&topicparent=Genome&onlywikiname=off&onlynewtopic=on&action=form&t=1298477059&formtemplate=TaxonProfile%2FBuilder.ProfileForm&Namespace=Genome&redirectto=http%3A%2F%2Fogg.lan%2FTaxonProfile%2FBuilder%2FProfileBuilder%3FNamespace%3DGenome%3Bqform%3DGenome_Sample_Form%233a_Create_a_new_Profile_Form

-- PaulHarvey - 23 Feb 2011

Haven't seen it for ages, let's close.

-- PaulHarvey - 17 Mar 2011