Item10756: trunk System.SiteMap crashes in logger code when using RcsWrap

Whileadding paging, I noticed that the Site maps's SEARCH was horribly innefficient, as it tested every topic to see if its name was the Web Pref topic.

so I've changed that, but the crash is still present in RcsWrap - if you run the following.. (will make a unit test)

%SEARCH{ "name='%WEBPREFSTOPIC%'" web="all" scope="topic" type="query" nototal="on" nosearch="on" format="<tr><td><img src=\"%ICONURL{web-bg}%\" alt=\"\" style=\"background-color:$pattern(.*?\* Set WEBBGCOLOR\s*=\s*([^\s]*).*)\" /><b>[[$web.%HOMETOPIC%][$web]]</b></td><td>[[$web.%HOMETOPIC%][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/home.gif\" alt=\"Home of $web web\" />]][[$web.WebSearch][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/searchtopic.gif\" alt=\"Search $web web\" />]][[$web.WebChanges][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/recentchanges.gif\" alt=\"Recent changes in the $web web\" />]][[$web.%NOTIFYTOPIC%][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/notify.gif\" alt=\"Get notified of changes to the $web web\" />]][[$web.%WEBPREFSTOPIC%][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/wrench.gif\" alt=\"Preferences of $web web\" />]][[$web.%STATISTICSTOPIC%][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/statistics.gif\" alt=\"Statistics of $web web\" />]][[$web.WebTopicList][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/indexlist.gif\" alt=\"Bullet list of all topics\" />]][[$web.WebIndex][<img src=\"%PUBURLPATH%/%SYSTEMWEB%/DocumentGraphics/index.gif\" alt=\"Index of all topics\" />]]</td><td>$percentEXPAND{\"$dollarpercentWEBSUMMARY$dollarpercent\" scope=\"$web.$topic\"}$percent $pattern(.*?\* Set SITEMAPUSETO\s*=([^\n\r]*).*)</td></tr>" }%

SiteChanges too:

Could not perform search. Error was: Can't call method "logger" on an undefined value at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/RcsLiteHandler.pm line 352.
at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/RcsLiteHandler.pm line 352
Foswiki::Store::VC::RcsLiteHandler::_process('Foswiki::Store::VC::RcsLiteHandler=HASH(0x1f321ce0)') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/RcsLiteHandler.pm line 214
Foswiki::Store::VC::RcsLiteHandler::_ensureProcessed('Foswiki::Store::VC::RcsLiteHandler=HASH(0x1f321ce0)') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/RcsLiteHandler.pm line 439
Foswiki::Store::VC::RcsLiteHandler::numRevisions('Foswiki::Store::VC::RcsLiteHandler=HASH(0x1f321ce0)') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/Handler.pm line 290
Foswiki::Store::VC::Handler::getLatestRevisionID('Foswiki::Store::VC::RcsLiteHandler=HASH(0x1f321ce0)') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/Store.pm line 123
Foswiki::Store::VC::Store::readTopic('Foswiki::Store::RcsLite=HASH(0x1255508)', 'Foswiki::Meta=HASH(0x1f321c08)', undef) called at /home/sven/src/foswiki/core/lib/Foswiki/Meta.pm line 1032
Foswiki::Meta::loadVersion('Foswiki::Meta=HASH(0x1f321c08)', undef) called at /home/sven/src/foswiki/core/lib/Foswiki/Meta.pm line 466
Foswiki::Meta::load('Foswiki::Meta', 'Foswiki=HASH(0x11f6f30)', 'Tasks', 'ActiveState') called at /home/sven/src/foswiki/core/lib/Foswiki/MetaCache.pm line 126
Foswiki::MetaCache::addMeta('Foswiki::MetaCache=HASH(0x22276f0)', 'Tasks', 'ActiveState') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/QueryAlgorithms/BruteForce.pm line 229
Foswiki::Store::QueryAlgorithms::BruteForce::_webQuery('Foswiki::Query::Node=HASH(0x26ee628)', 'Tasks', undef, 'Foswiki=HASH(0x11f6f30)', 'HASH(0x21b5cf8)') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/QueryAlgorithms/BruteForce.pm line 80
Foswiki::Store::QueryAlgorithms::BruteForce::query('Foswiki::Query::Node=HASH(0x26ee628)', undef, 'Foswiki=HASH(0x11f6f30)', 'HASH(0x21b5cf8)') called at /home/sven/src/foswiki/core/lib/Foswiki/Store/VC/Store.pm line 556
Foswiki::Store::VC::Store::query('Foswiki::Store::RcsLite=HASH(0x1255508)', 'Foswiki::Query::Node=HASH(0x26ee628)', undef, 'Foswiki=HASH(0x11f6f30)', 'HASH(0x21b5cf8)') called at /home/sven/src/foswiki/core/lib/Foswiki/Meta.pm line 891
Foswiki::Meta::query('Foswiki::Query::Node=HASH(0x26ee628)', undef, 'HASH(0x21b5cf8)') called at /home/sven/src/foswiki/core/lib/Foswiki/Search.pm line 353
Foswiki::Search::searchWeb('Foswiki::Search=HASH(0x2139ab8)', 'showpage', 1, 'search', 'info.author!=\'WikiGnome\'', 'basetopic', 'SiteChanges', 'date', '', ...) called at /home/sven/src/foswiki/core/lib/Foswiki/Macros/SEARCH.pm line 32
Foswiki::__ANON__() called at /usr/share/perl5/Error.pm line 416
eval {...} called at /usr/share/perl5/Error.pm line 408

-- SvenDowideit - 17 May 2011

Duplicate of Item10726, so don't forget to close them both

-- PaulHarvey - 18 May 2011

Doesn't apply to Release01x01. Or trunk, it seems. Closing; see Item10726

-- PaulHarvey - 18 Jun 2011

Commenting is disabled while not logged in