Item10991: I18N.pm still causes warnings because of uninitialized $tag under perl 5.12

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Engine
Component: I18N
Branches:
Reported By: ModAcOst
Waiting For:
Last Change By: CrawfordCurrie
Item10267 meant to fix this, but
lc($tag || '')
still causes errors in apaches errorlog when using perl 5.12. However
lc(($tag || ''))
will work as do
$tag = shift || '';
$tag = lc($tag);
and of course
    sub _normalize_language_tag {
        my $tag = shift;
        if ( not $tag ) { return '' }  # fix
        $tag = lc($tag);
from that item. I suppose the same is true for lib/Foswiki/UI/Save.pm line 495
    my $editaction = lc( $query->param('editaction') || '' );
and lib/Foswiki/UI/Edit.pm line 48
    my $editaction = lc( $query->param('action') || '' );
altough I've never seen anything in my logs about them.

-- ModAcOst - 20 Jul 2011

I really don't think this is important, and it's not something I've seen in the logs when working on 1.2.0 under 5.14, so marking as no-action.

-- CrawfordCurrie - 15 Jun 2015
 

ItemTemplate edit

Summary I18N.pm still causes warnings because of uninitialized $tag under perl 5.12
ReportedBy ModAcOst
Codebase 1.1.3, trunk
SVN Range
AppliesTo Engine
Component I18N
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r4 - 15 Jun 2015, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy