Item11153: SUBST macro processes and emits META lines

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: FilterPlugin
Branches:
Reported By: PaulHarvey
Waiting For:
Last Change By: MichaelDaum
Support.Faq60 currently produces
Original:
<hr />
Image: <img src="Foo.png"/>
<hr />
Transformed:
<hr />
Image: <img src="/pub/Support/Faq60/Foo.png"/>

But we wanted something like
Original:
<hr />
Image: <img src="Foo.png"/>
<hr />
Transformed:
<hr />
Image: <img src="/pub/Support/Faq60/Foo.png"/>

I.e. no META lines

patch:
diff --git a/lib/Foswiki/Plugins/FilterPlugin/Core.pm b/lib/Foswiki/Plugins/FilterPlugin/Core.pm
index ad8d4c8..a086e4c 100644
--- a/lib/Foswiki/Plugins/FilterPlugin/Core.pm
+++ b/lib/Foswiki/Plugins/FilterPlugin/Core.pm
@@ -20,6 +20,7 @@ use strict;
 
 use vars qw($currentTopic $currentWeb %seenAnchorNames $makeIndexCounter %filteredTopic);
 use POSIX qw(ceil);
+use Foswiki::Func();
 
 use constant DEBUG => 0; # toggle me
 
@@ -97,7 +98,7 @@ sub handleFilter {
   } else { # topic text
     return '' if $filteredTopic{"$theWeb.$theTopic"};
     $filteredTopic{"$theWeb.$theTopic"} = 1;
-    $text = Foswiki::Func::readTopicText($theWeb, $theTopic);
+    (undef, $text) = Foswiki::Func::readTopic($theWeb, $theTopic);
     if ($text =~ /^No permission to read topic/) {
       return showError("$text");
     }

-- PaulHarvey - 28 Sep 2011

True. Go ahead and check in the fix.

-- MichaelDaum - 29 Sep 2011

Committed - I think it can be uploaded now

-- PaulHarvey - 29 Sep 2011
 

ItemTemplate edit

Summary SUBST macro processes and emits META lines
ReportedBy PaulHarvey
Codebase trunk
SVN Range
AppliesTo Extension
Component FilterPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins FilterPlugin:b458780a1e16 FilterPlugin:a8443d439e81
TargetRelease n/a
ReleasedIn n/a
Topic revision: r6 - 29 Sep 2011, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy