Item11181: Create unit tests for core Table rendering, Issues found with header / footer markup

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Engine
Component: FoswikiRender
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
The core table code in Render.pm doesn't have any unit test coverage.

Created unit tests and noted issues:
  • <th> and <strong> are redundant in the table header. Should not need to generate the strong markup.
  • Code doesn't support generating table footers.

Since this behavior has been around forever, and is overridden by the TablePlugin, setting as enhancement, target Release 1.2

-- GeorgeClark - 13 Oct 2011

Found another issue - A list adjacent to a table doesn't terminate the list, so the table html runs together with the list markup. Fix to both were rather simple. Committing fixes to 1.2 - should I also apply to 1.1.4? Unit tests pass. Changed to normal. These are bugs, but masked by TablePlugin.

-- GeorgeClark - 13 Oct 2011

Between George and I we have fixed the core table rendering. However the TablePlugin remains at fault.

-- CrawfordCurrie - 14 Oct 2011

Will sync over to 1.1.4 - given that TablePlugin generally masks this issue, fix is low risk.

-- GeorgeClark - 14 Oct 2011
 

ItemTemplate edit

Summary Create unit tests for core Table rendering, Issues found with header / footer markup
ReportedBy GeorgeClark
Codebase 1.1.3, trunk
SVN Range
AppliesTo Engine
Component FoswikiRender
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:dc1cba10d651 distro:f569d88919f1 distro:edb0a8d7a14a distro:9727ad7b0065 distro:17bd8b5d0467 distro:9acceb5120e0 distro:d089cbeb1a42
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r12 - 17 Dec 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy