You are here: Foswiki>Tasks Web>AllOutStandingItems>PublishPlugin>Item11339 (30 Jul 2012, CrawfordCurrie)Edit Attach

Item11339: Item10944 broke Item10581 which broke...

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: PublishPlugin
Branches: trunk
Reported By: DiabJerius
Waiting For:
Last Change By: CrawfordCurrie
Item10581 broke the output relative resource path if the default resource path was in use (Item10944). The analysis of the problem was correct however the fix was incorrect, resulting in breakage if a non-default resource path is used.

_rsrcpath() is designed to be passed two "absolute" paths, both rooted at / (which is actually the directory relativedir/outfile). The bug is that while a user provided resource path was prefixed with /, the default was set to rsrc instead of /rsrc.

The attached patch makes that change and reverts the gist of the incorrect fix.

-- DiabJerius - 08 Dec 2011

Please see Item11345 for an enhanced version of this patch.

-- DiabJerius - 09 Dec 2011

Patch applied.

-- CrawfordCurrie - 30 Jul 2012

 

ItemTemplate edit

Summary Item10944 broke Item10581 which broke...
ReportedBy DiabJerius
Codebase
SVN Range
AppliesTo Extension
Component PublishPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins PublishPlugin:0dbee3f2b001
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches trunk
trunkCheckins PublishPlugin:0dbee3f2b001
Release01x01Checkins
I Attachment Action Size Date Who Comment
PublishPlugin-2.3.2.patchpatch PublishPlugin-2.3.2.patch manage 629 bytes 08 Dec 2011 - 04:15 DiabJerius Patch
Edit  | Attach | Print version | History: r5 < r4 < r3 < r2 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r5 - 30 Jul 2012, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy