Item11590: Why are the pattern skin fonts set in #patternPage a div id half way into the page?
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
surely this kind of css could use the html body selection and thus apply to any skin, and all rendered html?
I presume that is why the styling of the 'Create Task' jq popup I just added is naf - the dialog html gets added to the end of the body.
There are a number of pains here
- the font is set on an id
- the id is nested quite a way down
- why put general styling on a skin and application specific css class or element? Would it not be better to style the body with generally good defaults, and then use classes and id's to tweak them?
(I ask because I don't
know, but as a programmer, is feels strange.)
--
SvenDowideit - 01 Mar 2012
Strange, there has been no
#patternPage
since that changed to
.foswikiPage
on 16 Jun 2009, see
http://trac.foswiki.org/changeset/4168.
When I wrote that I had a kind of font size default in mind, a reset on the body tag and an override (the actual size) on the
nearest div (not half a page away).
Today I wouldn't write it that way.
--
ArthurClemens - 06 Mar 2012
Setting to no action.
--
GeorgeClark - 30 Dec 2014