Item11630: Fix custom fullscreen hack from Item10288

pencil
Priority: Urgent
Current State: No Action Required
Released In: 1.1.5
Target Release: patch
Applies To: Extension
Component: TinyMCEPlugin
Branches:
Reported By: PaulHarvey
Waiting For: PaulHarvey
Last Change By: PaulHarvey
This is a more a note-to-self (and Crawford) to either re-apply the fullscreen MCE plugin hack used in Item10288, or change the solution so as not to rely on patching TinyMCE's distributed files

This applies to 1.1.5 if we are going to be shipping trunk's TinyMCEPlugin

-- PaulHarvey - 09 Mar 2012

Don't forget to update TinyMCEPlugin update procedure to remove the patch step (or not).

-- PaulHarvey - 09 Mar 2012

I wasn't involved in the hack AFAIK and can't work out what has to be done from all the checkins, so deferring to Paul who should...

-- CrawfordCurrie - 23 Mar 2012

I don't think we need anything here. Just checked the latest tmce on 1.1.5, and I don't see the original issue. Problem was that the shortcut key - Ctrl-Shift-S to trigger the WYSIWYG save, would attempt to save from full screen and loose all changes. The fix was to intercept with JS and popup an error saying to exit from fullscreen before attempting to save. I've checked locally and on foswiki.org
  • Alt-Shift-S, Alt-Shift-K and Alt-Shift-Q save in wysiwyg and popup an error in fullscreen
  • Alt-Shift-C cancels in both wysiwyg and fullscreen.
  • Alt-Shift-P (preview) is inactive in both modes when using firefox.

-- GeorgeClark - 24 Mar 2012

I see that we actually reverted the initial hack. Closing.

-- PaulHarvey - 26 Mar 2012
 

ItemTemplate edit

Summary Fix custom fullscreen hack from Item10288
ReportedBy PaulHarvey
Codebase trunk
SVN Range
AppliesTo Extension
Component TinyMCEPlugin
Priority Urgent
CurrentState No Action Required
WaitingFor PaulHarvey
Checkins
TargetRelease patch
ReleasedIn 1.1.5
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r4 - 26 Mar 2012, PaulHarvey
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy