Item11779: don't manipulate {webName} and {topicName} during save or edit

pencil
Priority: Urgent
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: HomePagePlugin
Branches: trunk
Reported By: MichaelDaum
Waiting For:
Last Change By: CrawfordCurrie
Problems:

  • this plugin should skip any actions when not in view or login context.
  • it redirects to topics that don't exist
  • it tries to redirect to a HomePage address that isn't a proper web.topic value

Missing features:

  • there's a TODO in the sources that should be fixed: making the formfield name read from the user's profile page configurable
  • instead of reading a HomePage formfield value, how about using preference settings instead? is makes more sense for setups where there is no form attached to user profiles.

-- MichaelDaum - 19 Apr 2012

distro:a0ff86ce986d broke the plugin unit tests.

-- CrawfordCurrie - 01 May 2012

CDot, HomePagePlugin was causing serious data loss on some wiki apps manipulating the session internals during a save, which basically was a disaster in at least one case. This got fixed.

If the fixes broke the tests, the tests are wronky as well.

-- MichaelDaum - 07 May 2012

The tests were fine; but the core code was testing for the existence of the landing page, which it doesn't need to do. The standard in Foswiki is if a page does not exist, then we prompt to create it.

Added tests for view and save contexts.

-- CrawfordCurrie - 07 May 2012
 

ItemTemplate edit

Summary don't manipulate {webName} and {topicName} during save or edit
ReportedBy MichaelDaum
Codebase trunk
SVN Range
AppliesTo Extension
Component HomePagePlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:a0ff86ce986d
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches trunk
trunkCheckins distro:a0ff86ce986d
Release01x01Checkins
Topic revision: r8 - 07 May 2012, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy