Item11831: MetaCommentPlugin and TopicInteractionPlugin don't works

Because I didn't get any help (from IRC) where can be the bug, this report will not be as my usual detailed reports. Now only, The:

• MetaCommentPlugin
• TopicInteractionPlugin

simple don't works - Bugged as hell.

Symptoms

after pressing "Save" for adding a new comment, in the browser got only as result:

{"jsonrpc":"2.0","result":null}

As MichaelDaum suggest, here is some bug with "redirectto". My script didn't get any "redirectto" argument, so in the Foswiki::Contrib::JsonRpcContrib::Server the code:

  # finally
  my $redirectto = $request->param("redirectto");   #<--- this is undefined all times
  if ($code == 0 && defined $redirectto) {  #<--- the $code == "0", but the $redirectto is undefined, so
    my $url;
    if ($redirectto =~ /^https?:/) {
      $url = $redirectto;
    } else {
      $url = $session->getScriptUrl(1, 'view', $session->{webName}, $redirectto );
    }
    $session->redirect($url);
  } else { #<--- so exetuted this "else", but the $code is "0", and the $result is undef - so... #SMELL!!!
    Foswiki::Contrib::JsonRpcContrib::Response->print($session,
      code => $code,
      message => $result,
      id => $request->id()
    );
  }

IMHO, Somewhere in tmpl files missing

<input type="hidden" name="redirectto" value="%BASEWEB%.%BASETOPIC%" />

When added the above line into metacoments.tmpl, the comments starts work, but after when I installed the TopicInteractionPlugin - the adding comments stop works again..

Sadly, because otherwise it is an nice plugin, with polished look...

Ps: BTW, would be nice trying installing plugins into clean FW installations (as me do it - for testing). For example, the above plugins need ImagePlugin to work, otherwise the user get some %IMAGE{... garbage... }. The ImagePlugin is not installed automatically, so probably it is missing from dependency list.

How to reproduce: Install clean FW, install the MetaCommentPlugin - and check...

-- JozefMojzis - 07 May 2012

I second Jozefs remark regarding installation of plugins into a clean FW setup to find dependency errors. For example, I couldn't get the attachment functions working with TopicInteractionPlugin that originally are provided via the standard foswiki attach dialog, obviously there's something missing in my freshly installed naked foswiki 1.1.5 installation that isn't resolved automatically or is missing in the documentation. Don't get me wrong: both plugins are great and I personally think at least TopicInteractionPlugin should be a core plugin. Hope I find out why it doesn't work properly on my setup soon, so that I can post some feature requests.

-- FranzJosefGigler - 07 May 2012

Treacherous, there seems to be an undocumented dependency to the DBCachePlugin for TopicInteractionPlugin (derived from the entry in error.log). Since I have installed and activated that Plugin everything works like a charme! Great plugin Micha!

-- FranzJosefGigler - 07 May 2012

Regarding the use of both MetaCommentPlugin and TopicInteractionPlugin at the same time: it is definitely not clear from the documentation how to set the SKIN value to get this working with the PatternSkin. Slightly frustrating, but I'm happy that I could get TIP up and running. Maybe Jozef has more luck.

-- FranzJosefGigler - 07 May 2012

FranzJosefGigler - THANK YOU. The DBCachePlugin solved my problems deleting attachments... Anyway, the problem adding comments via MetaCommentPlugin still remains...

-- JozefMojzis - 08 May 2012

Found the error why MetaCommentPlugin and TopicInteractionPlugin don't work. This is an integration error with PatternSkin.

Also: I will remove the dependency on DBCachePlugin.

-- MichaelDaum - 08 May 2012

Fixed in latest releases of MetaCommentPlugin and TopicInteractionPlugin

-- MichaelDaum - 08 May 2012

Thank you for for your fix. As FranzJosefGigler told, those two plugins should be in the CORE. Two of the best plugins in FW.

-- JozefMojzis - 08 May 2012

Sorry, once again have {"jsonrpc":"2.0","result":null} problem. Foswiki 1.1.9, upgrade from 1.1.8 JsonRpcContrib 2.11 MetaCommentPlugin is the latest (21.3.2014).

-- ValentinKozlov - 21 Mar 2014

Reply to myself: TopicInteractionPlugin is used too in my case. It is necessary that in "Set SKIN" not only "topicinteraction" is included but also "metacomment". Once I added "metacomment" in SKIN settings (as it is recommended in the TopicInteraction page), everything works fine.

-- ValentinKozlov - 22 Mar 2014

Commenting is disabled while not logged in