You are here: Foswiki>Tasks Web>Item12085 (02 Dec 2014, GeorgeClark)Edit Attach

Item12085: Extension installer does not handle shipped rcs ,v files correctly

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Engine
Component: Configure
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
During installation there are a couple of issues:

  • The comma is the manifest delimiter. This is being addressed by Item8898 for new packages, but needs to be handled for older packages.
  • The related .txt file is "checked in" because the previous ",v" file exists on disk, then the ",v" file is overlaid by the shipped file
    • The file timestamp on the checked in file is newer than the shipped ",v" file, resulting in an extra revision when the topic is viewed.

The installer assumes that if ,v rcs files exist on disk, then there have been local modifications that should be retained in history and forces a "check-in" even for files marked (noci) in the manifest. When a ,v file is shipped, we will end up discarding history of local modifications. However this is all done for just a single instance. The CompareRevisionsAddOn ships a demo file with history to show capabilities of the topic revision history.

When a ,v file is shipped, we need to flag the related file to ensure that it is copied rather than checked in, so that revision history is correct. Local modifications will be lost from history, but would still be in the backup archive taken during extension installation.

-- GeorgeClark - 22 Sep 2012

Another very long standing issue. Deferring to 1.2.

-- GeorgeClark - 02 Nov 2012

Changing this to no action. We should not ship ,v files under any conditions, especially now that we have the PlainFile store.

-- GeorgeClark - 02 Dec 2014

ItemTemplate edit

Summary Extension installer does not handle shipped rcs ,v files correctly
ReportedBy GeorgeClark
Codebase 1.1.5, trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r3 - 02 Dec 2014, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy