Item12313: serious performance impact calling initTOPIC in commonTagsHandler

pencil
Priority: Urgent
Current State: Closed
Released In: n/a
Target Release:
Applies To: Extension
Component: WorkflowPlugin
Branches: trunk
Reported By: MichaelDaum
Waiting For:
Last Change By: CrawfordCurrie
commonTagsHandler is potentially called quite often on a single topic view, i.e. while rendering results of a formatted search.

Tracing down some strange slowdown of search I've found that this was caused by pushTopicContext called repeatedly by WorkflowPlugin (via commonTagsHandler and initTOPIC). The code tries to find out whether the web.topic passed to initTOPIC is under workflow control or not by reading preference settings.

This operation is rather expensive and sums up to a couple of seconds rendering time on top of the rest of the formatted search.

On my laptop a search rendering a plain list of 1.1k topics came down from 8-9 seconds to 800ms. So that's a serious foul egg in WorkflowPlugin.

-- MichaelDaum - 23 Dec 2012

I changed it to be a bit smarter about when it calls initTOPIC.

-- CrawfordCurrie - 08 Aug 2014

 

ItemTemplate edit

Summary serious performance impact calling initTOPIC in commonTagsHandler
ReportedBy MichaelDaum
Codebase
SVN Range
AppliesTo Extension
Component WorkflowPlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins WorkflowPlugin:fd690d1f5185
ReleasedIn n/a
CheckinsOnBranches trunk
trunkCheckins WorkflowPlugin:fd690d1f5185
Release01x01Checkins
Topic revision: r3 - 08 Aug 2014, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy