Item12357: Edit command cmd=repRev
fails to save the modified topic.
Priority: Urgent
Current State: Closed
Released In: 1.2.0
Target Release: minor
Applies To: Engine
Component: FoswikiUIEdit
Branches: Release01x01 trunk
The
cmd=repRev
fails to save the changes.
Found while fixing the
TestCaseAmISane tests.
Works on Release 1.1
--
GeorgeClark - 19 Jan 2013
Issue is that cmd=repRev fails to invalidate the cache. So the original topic is still displayed to the user.
--
GeorgeClark - 12 Apr 2013
I added fireDependency calls - please verify that this fixes it for you (the unit tests for the cache are useless)
--
CrawfordCurrie - 12 Apr 2013
Something isn't quite right. The cache is now refreshed, and it keeps the same rev, but the author is revised for that rev from original to
AdminUser. Confirmed on trunk.foswiki.org, and validated expected behavior on foswiki.org:
- foswiki.org: cmd=repRev preserves the topicinfo, including timestamp and original author
- trunk.foswiki.org Author is changed to AdminUser for that revision.
Do you want another task? Or can I expand the scope of this one?
--
GeorgeClark - 12 Apr 2013
OK, confirmed. I added a unit test to make sure this doesn't get missed.
--
CrawfordCurrie - 12 Jun 2013
Synced the unit test to 1.1. It passes on 1.1, except I had to add 60 seconds to the timestamp. Store bumps the timestamp to avoid complaints by rcs.
--
GeorgeClark - 28 Oct 2013