Item12380: Configure IE Compatibility fixes break Firefox / Chromium

pencil
Priority: Urgent
Current State: No Action Required
Released In: 1.2.0
Target Release: minor
Applies To: Engine
Component: Configure
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: JanKrueger
I'm seeing some occasional strangeness:

  • Cursory Checks, and Extended Checks do work, but give me an empty js popup first.
  • The error report looks normal once the popup is dismissed.
  • Once that happens, none of the other modals work, including save changes They all produce the same empty modal, even a "save changes" with no unsaved changes, just pops up empty.
  • There are no js errors in the console
  • non-modals continue to work fine (log viewer for example)

A shift-reload fixes everything, save reports the No unsaved changes pop-up, and all is good, until I try a cursory checks again.

I've tried chromium and it fails the same way, so at least Firefox and Chromium are consistent.

Just in case it was configure related, I deleted the configuration and was able to recreate it.

I started bisect to find a rev where it started working.

  • works at rev 16452 (before the IE fixes)
  • works at rev 16453 (after IE fixes part 1)
  • fails at rev 16457 (after IE fixes part 2)

So it looks like the part 2 fixes for IE broke Firefox and Chromium

-- GeorgeClark - 03 Feb 2013

I'll take this one.

-- JanKrueger - 15 Mar 2014

Just tested in Chromium using current trunk and I'm not seeing any empty modals. Admittedly, the output of Cursory/Extended Checks looks rather dodgy, but I can't reproduce any of the rest.

-- JanKrueger - 15 Mar 2014

Jan, Can we set this to no action?

-- GeorgeClark - 28 Apr 2014

I think so, and I'm just going to set it right now.

-- JanKrueger - 28 Apr 2014
 

ItemTemplate edit

Summary Configure IE Compatibility fixes break Firefox / Chromium
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Urgent
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease minor
ReleasedIn 1.2.0
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r5 - 28 Apr 2014, JanKrueger
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy