You are here: Foswiki>Tasks Web>Item12413 (19 Nov 2013, GeorgeClark)Edit Attach

Item12413: Crash in Foswiki/Net.pm when using perl 5.16 and later.

Priority: Urgent
Current State: Closed
Released In: 1.1.9
Target Release: patch

Applies To: Engine
Component: FoswikiNet
Branches: Release01x01 trunk

Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark

Perl 5.16 deprecated use of "defined" for aggregates (arrays and hashes). The changes in Net.pm causes a compile error on perl 5.16.

Fix is:

diff --git a/core/lib/Foswiki/Net.pm b/core/lib/Foswiki/Net.pm
index a0a7346..ad1b930 100644
--- a/core/lib/Foswiki/Net.pm
+++ b/core/lib/Foswiki/Net.pm
@@ -593,7 +593,7 @@ s/([\n\r])(From|To|CC|BCC)(\:\s*)([^\n\r]*)/$1 . $2 . $3 . _fixLineLength( $4 )/
         package Foswiki::Net::Mail;
         our @ISA;
 
-        unless ( defined @ISA ) {
+        unless ( @ISA ) {
             @ISA            = @Net::SMTP::ISA;
             @Net::SMTP::ISA = __PACKAGE__;
         }

-- GeorgeClark - 02 Mar 2013

ItemTemplate edit

Summary	Crash in Foswiki/Net.pm when using perl 5.16 and later.
ReportedBy	GeorgeClark
Codebase	1.1.8, trunk
SVN Range
AppliesTo	Engine
Component	FoswikiNet
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	distro:47816304f164 distro:2ebbce2433e2
TargetRelease	patch
ReleasedIn	1.1.9
CheckinsOnBranches	Release01x01 trunk
trunkCheckins	distro:2ebbce2433e2
Release01x01Checkins	distro:47816304f164