Item12524: hard-coded form and attachment tables at the bottom of a compare-page

pencil
Priority: Enhancement
Current State: Waiting for Feedback
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: CompareRevisionsAddOn
Branches:
Reported By: MichaelDaum
Waiting For: Main.StephanOsthold
Last Change By: MichaelDaum
This extension tinkers with the skin path and forces a %META{"form"}% and %META{"attachments"}% to be displayed at the bottom of a compare page. This cannot be removed, not even by nulling related TMPL-DEFs in formtables.xxx.tmpl.

-- MichaelDaum - 03 Jun 2013

Postponed until 1.2.x as per decision at the IRC release meeting.

-- JanKrueger - 14 Oct 2013

I do have a solution for this, however I'm not entirely happy with it. It is a rewrite that introduces a COMPARE macro allowing better flexibility.

Pros:
  • You can remove attachments and form ^^
  • You can compare anything you can put into a TMPL:DEF
  • Macros and macro parameters, no more %REPEAT%
  • If you're crazy enough you can mix side-by-side and interweave
  • You can place the comparisons anywhere in your view template

Drawbacks:
  • It requires a %TMPL:DEF{"compareelements"}%topic, form, attachments%TMPL:END% where you specify which elements you want to compare
  • It breaks backwards compatibility if you have customized templates/comparesidebyside.tmpl or templates/compareinterweave.tmpl
  • It seems too big a rewrite for a minor release

-- StephanOsthold - 17 Mar 2014

As this is now one of the main release blockers prior to a 1.2 alpha/beta, I think we should defer this. It is a rather extensive change. Michael, this was originally your task, please comment on whether this should block 1.2. Major / extensive changes late in the release process seem ill advised. Thanks.

-- GeorgeClark - 18 Dec 2014

Let's defer.

-- MichaelDaum - 18 Dec 2014
 

ItemTemplate edit

Summary hard-coded form and attachment tables at the bottom of a compare-page
ReportedBy MichaelDaum
Codebase 1.1.8, trunk
SVN Range
AppliesTo Extension
Component CompareRevisionsAddOn
Priority Enhancement
CurrentState Waiting for Feedback
WaitingFor StephanOsthold
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r8 - 18 Dec 2014, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy