Item12723: FlexFormPlugin: $value identical to $origvalue since Foswiki 1.1.9

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release:
Applies To: Extension
Component: FlexFormPlugin
Branches:
Reported By: JanKrueger
Waiting For:
Last Change By: MichaelDaum
Foswiki 1.1.9 changed the default behaviour for renderForDisplay in value-mapped fields: by default, all fields are rendered with their unmapped values. Whether this was the right choice is maybe debatable, but fortunately an option was introduced to influence the behaviour.

This should do the trick:

diff --git a/lib/Foswiki/Plugins/FlexFormPlugin/Core.pm b/lib/Foswiki/Plugins/FlexFormPlugin/Core.pm
index 289c740..cb3850c 100644
--- a/lib/Foswiki/Plugins/FlexFormPlugin/Core.pm
+++ b/lib/Foswiki/Plugins/FlexFormPlugin/Core.pm
@@ -289,6 +289,7 @@ sub handleRENDERFORDISPLAY {
     $line = $field->renderForDisplay($line, $fieldValue, {
       bar=>'|', # SMELL: keep bars
       newline=>'$n', # SMELL: keep newlines
+      display=>1,
     }); # SMELL what about the attrs param in Foswiki::Form
         # SMELL wtf is this attr anyway

-- JanKrueger - 20 Jan 2014

That's been fixed in FlexFormPlugin:7e2cf5bb3bbf already as part of Item12466.

-- MichaelDaum - 20 Jan 2014
 

ItemTemplate edit

Summary FlexFormPlugin: FlexFormPlugin: =$value identical to $origvalue since Foswiki 1.1.9= identical to $origvalue since Foswiki 1.1.9
ReportedBy JanKrueger
Codebase
SVN Range
AppliesTo Extension
Component FlexFormPlugin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r2 - 20 Jan 2014, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy