Item12735: EditRowPlugin addrow functionality destroys table structure

pencil
Priority: Urgent
Current State: Closed
Released In: n/a
Target Release: minor
Applies To: Extension
Component: EditRowPlugin
Branches: trunk
Reported By: ZsoltBalog
Waiting For:
Last Change By: CrawfordCurrie
Hi, I have strange problems with the EditRowPlugin, as I'm newbie with FosWiki, it can be my fault. I could repeat the issue with this structure.
%EDITTABLE{ format="| text,100 | text,100 |" headerislabel="on"}%
| *heada* | *headb* |
| one | onepair |
| two | twopair |

After pushing the button for table editing, and adding a row, the table lost it's base structure (in this case the heading). Pushing it multiple times gives even more strange result. The addrow feature in the row editor gives similar result:
%EDITTABLE{ format="| text,100 | text,100 |" headerislabel="on"}%
| ||
| *heada* | *headb* |
| one | onepair |
| two | twopair |

Originally I used a longer EDITTABLE row. The topic contained only this short table. After pushing any EditRowPlugin buttons, not just the table but the EDITTABLE row was obfuscated. After the 117th character it was cut, and the second part became the first row of the topic followed by 2 empty lines and the other half. This was my original line:
%EDITTABLE{ format="| text, 20 | select, 1 %SEARCH{ "^\|[^\*\|]*\|" topic="ServicesInternal" type="regex" multiple="on" nonoise="on" format=", $pattern(^ *\| *(.*?) *\|.*)" }%|" changerows="on" }%   

Cheers, bazso

-- ZsoltBalog - 27 Jan 2014

At least part of the issue appears to be that EditRowPlugin always adds new rows at the top of the table. It is documented as adding rows at the end of the table.

-- GeorgeClark - 22 Mar 2014

The trunk version destroyed the first table in GitConversionTasks. It lost all but the first column in the first two rows of the first table. See r2 vs. r3. I clicked the + twice to add rows at the end. They went to the top. I then positioned the cursor in the first row, pressed, -, but nothing happened. cancelled the edit pressing the red X, but the table saved anyway. and the columns were lost.

-- GeorgeClark - 22 Mar 2014

I can see the first of the problems that Bazso reports, and have fixed it. I can't see any problem with the EDITTABLE line, however - it works fine for me using that test line (while I had already fixed the first problem it can have had no impact on the second problem). George, try as I might I can't manage to delete columns from anywhere in the table. Can you give me a simple example I can use to reproduce the problem?

-- CrawfordCurrie - 22 Mar 2014

OK, I tracked down the other problem and fixed it.

-- CrawfordCurrie - 23 Mar 2014

 
Topic revision: r10 - 23 Mar 2014, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy