Item12766: Incorrect Form data displayed for historical page versions

pencil
Priority: Urgent
Current State: Closed
Released In: n/a
Target Release:
Applies To: Extension
Component: TopicInteractionPlugin
Branches: trunk
Reported By: RickMach
Waiting For:
Last Change By: MichaelDaum
If I use the TopicInteractionPlugin as part of the NatSkin or as part of the PatternSkin I see this error. If you view an older revision of the topic (view/Web/TopicName?rev=1) the value shown on the page for the form data still contains the form data associated with the latest revision. If I disable the plugin from the pattern skin, choosing the older revision shows the proper data for the form.

-- RickMach - 05 Mar 2014

Here's the fix:

--- templates/metadata.tmpl     (revision 17305)
+++ templates/metadata.tmpl     (working copy)
@@ -101,6 +101,7 @@
 %TMPL:DEF{"dataform::tab"}%<!-- -->
 %RENDERFORDISPLAY{
   topic="%BASEWEB%.%BASETOPIC%"
+  revision="%URLPARAM{"rev"}%"
   excludeattr="[hH]"
   header="$percntTAB{\"%MAKETEXT{"Data form"}%\" id=\"dataform\"}$percnt
           <div class='foswikiFormSteps foswikiDataForm jqUITooltip' data-theme='info' data-position='top' data-arrow='true'>

-- MichaelDaum - 07 Mar 2014

Thanks! I have verified this resolves the issue when I hand edit the specified file.

-- RickMach - 07 Mar 2014
 

ItemTemplate edit

Summary Incorrect Form data displayed for historical page versions
ReportedBy RickMach
Codebase 1.1.9
SVN Range
AppliesTo Extension
Component TopicInteractionPlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins TopicInteractionPlugin:03b5b60946a7
ReleasedIn n/a
CheckinsOnBranches trunk
trunkCheckins TopicInteractionPlugin:03b5b60946a7
Release01x01Checkins
Topic revision: r5 - 18 Mar 2014, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy