Item12841: Aliases are not parsed correctly.

pencil
Priority: Normal
Current State: New
Released In: n/a
Target Release:
Applies To: Extension
Component: LoginNameAliasesPlugin
Branches:
Reported By: LloydParkes
Waiting For:
Last Change By: LloydParkes
The documentation for this plugin says this:
In addition to these settings, the plugin topic may contain aliases. An alias entry is a single line of the form:
<multiple of 3 spaces>*<space>ALIAS:<space><string><space><username>
For example:
	* ALIAS: johns@BAR.COM jsmith

Unfortunately the regular expression that is used doesn't match this. Instead, the regular expression requires that the alias like start with one or more TAB characters instead of one or more sets of three spaces. I verified this by editing the file with vi.

So, I'm new to Foswiki and I've seen that with the WYSYWIG editor lists are indented with a TAB, while the wiki text editor (which I use) cannot (easily) insert a TAB character. In addition to that, the two different indentation styles are rendered the same way, so you can't tell the difference when looking at the page.

I changed the regex on line 260 of LoginNameAliasesPlugin.pm to be
^(?:\t|   )+\* ALIAS: (\S+) (\S+)\s*$

In addition to grouping TAB with three spaces at the start of the regex I have changed \s to be actual space characters because the documentation says spaces rather than whitespace and making the regex match that removes a few leaning toothpicks. I left the last \s in place because trailing whitespace is much harder to find and fix than an accidental double space character. I don't expect everyone to agree with this additional change.

-- LloydParkes - 02 Apr 2014

 

ItemTemplate edit

Summary Aliases are not parsed correctly.
ReportedBy LloydParkes
Codebase 1.1.9
SVN Range
AppliesTo Extension
Component LoginNameAliasesPlugin
Priority Normal
CurrentState New
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r1 - 02 Apr 2014, LloydParkes
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy