Item13064: "Expert" Elements with errors are hidden from the UI

pencil
Priority: Urgent
Current State: Closed
Released In: 1.2.0
Target Release: minor
Applies To: Engine
Component: Configure
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: CrawfordCurrie
Errors without element shown is somewhat mysterious. If checkers detect an issue, the element needs to be visible regardless of
  • Expert status
  • DISPLAYIF status

Currently the user needs to show expert settings, and if the element isn't revealed, find and change the element dependent as the DISPLAYIF condition to reveal the error element.

From Item12952: AuthScripts hidden if something other than TemplateLogin set, but checker flags error for AuthScripts if something other than TemplateLogin set. Detailed errors and warnings should probably be visible at all times. - This is a problem with the checker, and not with configure per se.

(Regardless, if an element has an error it should not be hidden).

-- GeorgeClark - 02 Nov 2014

The point is that the element doesn't have an error (at least not if it's changed in the same configure session.

AuthScripts has a DISPLAY_IF on LoginManager, but there's no way for the interface to know that a dependency exists between the two. The dependency is hidden deep inside the checker, and won't be triggered unless all checkers are run - something we're trying to avoid.

The solution is to add a CHECK_ON_CHANGE option to .spec items - something I was trying to avoid, as it's tricky and expensive.

Oh, and we need to be able to see broken experts, as you say. That's a JS fix.

-- CrawfordCurrie - 03 Nov 2014

Hm. There is still an issue here. If the whole TAB is hidden, then the fields are not revealed. The example case is the Store -> File System Settings. When the server is running with suexecUserGroup set, the umask is too restrictive, and the checker returns an error against {Store}{overrideUmask}

-- GeorgeClark - 06 Nov 2014

The error is signalled through the tab and in the text at the top of the section. Yes it's hidden when it first opens but it's not rocket science to realise it's an expert setting. So while this is a fault, it's not really a release blocker IMHO.

Later: turned out it was fairly trivial to fix.

-- CrawfordCurrie - 08 Nov 2014

 

ItemTemplate edit

Summary "Expert" Elements with errors are hidden from the UI
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:32f15529eee0 distro:b7d4d43794c4
TargetRelease minor
ReleasedIn 1.2.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:32f15529eee0 distro:b7d4d43794c4
ItemBranchCheckins
Release01x01Checkins
Topic revision: r8 - 08 Nov 2014, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy