Item13110: Rowspans appear to be not working again

pencil
Priority: Urgent
Current State: Closed
Released In: 1.2.0
Target Release: minor
Applies To: Extension
Component: JQTablePlugin
Branches: master
Reported By: GeorgeClark
Waiting For:
Last Change By: CrawfordCurrie
Item12974 does not appear to have been fixed.

Demonstration table is in that task.

-- GeorgeClark - 24 Nov 2014

L C R
A2 B2 C2
A3 B3 C3
multi span
A5-7 5 5
six six
seven seven
split over 3 lines
A9 B9 C9
^ B10 |
^ B11 |

Hm, it starts working when there is a %TABLE macro in front.

-- MichaelDaum - 18 Dec 2014

It's working as designed. TablePlugin is only supposed to active when there is a TABLE macro present. If it's working on other tables that are not %TABLE tables, then that runs contrary to the doc (which only shows it working on %TABLE tables)

I can see the argument for making carat work on other non %TABLE tables as well - but we increasingly approach the point where this sort of handling needs to be in the core, not done by a plugin.

I changed it to support tables with no %TABLE tag, so it matches with your expectations.

-- CrawfordCurrie - 19 Dec 2014

Now JQTablePlugin depends on PatternSkin. It requires a div.foswikiTopic element to be present somewhere ... which is not the case for NatSkin. All Foswiki tables are using the css class foswikiTable. Why not process these instead of div.foswikiTopic table?

-- MichaelDaum - 19 Dec 2014
 
Topic revision: r7 - 21 Dec 2014, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy