Item1356: (trunk) rdiff does not show any changes

On the trunk, rdiff shows no changes between revisions.

In Foswiki::UI::RDiff.pm, at about line 525, after the calls to Foswiki::Meta->load(), $topicObject{$r2}->getLoadedRev() does not match $r2. Same for $r1. Both "loaded revisions" are the same as the topic's latest revision. So the call to getDifferences returns no differences (because the latest revision is the same as the latest revision).

I am running trunk revision 3240, with RcsWrap.

-- MichaelTempest - 22 Mar 2009

Update: There is a conflict between these two functions/methods:

• Foswiki::Store::VCStore::readTopic() returns $handler->numRevisions(), irrespective of the revision that was loaded.
• Foswiki::Meta::reload() calls Foswiki::Store::VCStore::readTopic(), but it expects the return value to be the revision number of the revision that was loaded.

-- MichaelTempest - 22 Mar 2009

Thanks for the analysis Michael, I'll look into that.

-- CrawfordCurrie - 03 Apr 2009

Reckon that should fix it.

-- CrawfordCurrie - 03 Apr 2009