Item13572: EditRowPlugin and EditTablePlugin Test case from hell

pencil
Priority: Urgent
Current State: No Action Required
Released In: n/a
Target Release: patch
Applies To: Extension
Component: EditRowPlugin
Branches:
Reported By: KennethLavrsen
Waiting For:
Last Change By: CrawfordCurrie
The worst = the most complex EDITTABLE / TABLE I have on my wiki must be the one where we have 6-8 tables where we plan prototype material

It is very confidencial so I have spent an hour making a simple version which still has the needed complexity.

You can consider EditRowPlugin stable when you can

  • View these tables without errors.
  • Edit these tables with errors
  • Edit these tables and ther CALCs still work
  • Add rows and the right default formulas work and the new row is added before the footer row as defined in the TABLE macro

This test case passes with no problem in Foswiki 2.0.1 current RC1 from GIT HEAD today with EditRowPlugin disabled and EditRowPlugin enabled.

  • Set FORMULAFROMHELL = $EVAL( ($T(R$ROW():C4)+0) * $GET(MTSCAB2) + ($T(R$ROW():C5)+0) * $GET(MTSCAB4) + ( ( ($T(R$ROW():C4)+0) + ($T(R$ROW():C5)+0) ) * ($T(R$ROW():C6)+0) + ($T(R$ROW():C7)+0) ) * $GET(BR) + ($T(R$ROW():C8)+0) * $GET(XCVR) + ($T(R$ROW():C9)+0) * $GET(PA) + ( ( ($T(R$ROW():C4)+0) + ($T(R$ROW():C5)+0) ) * ($T(R$ROW():C10)+0) * $GET(SC) ) + ( ($T(R$ROW():C4)+0) + ($T(R$ROW():C5)+0) ) * ($T(R$ROW():C11)+0) * $GET(PSU) + ($T(R$ROW():C4)+0) * $GET(RFDS2) + ($T(R$ROW():C5)+0) * $GET(RFDS4) )

Item Cost (USD) Comments
Item 1
4000
Blabla
Item 2
1500
Bla
Item 3
965
Bla
Item 4
550
Blabla
Item 5
480
Blablub
Item 6
415
Bluebla
Item 7
325
Trala
Item 8
5907
Doobeedoo
Item 9
900
Oh yes

Customer Pass Purpose Product 1 Product 2 Item per Product Extra 1 Component A Component B Component 3 (per) Component 4 (per) Acces for P1 Access for P2 Cost (USD) When (Q)
Total
 
 
3
2
16
6
41
25
8
5
3
2
64634
 
Group 1
P1
Something
 
 
 
 
10
3
 
 
 
 
6045
Q2-15
Group 2
P1
Something
 
 
 
 
5
 
 
 
 
 
2400
Q2-15
Group 3
P1
Something
 
 
 
 
4
 
 
 
 
 
1920
Q2-15
Group 4
P1
Something
3
 
4
4
 
 
2
1
3
 
26915
Q2-15
Group 5
P1
Something
 
2
2
2
 
 
1
1
 
2
27354
Q2-15

Phase1/Proto 1B - Engineering

Customer Pass Purpose Product 1 Product 2 Item per Product Extra 1 Component A Component B Component 3 (per) Component 4 (per) Acces for P1 Access for P2 Cost (USD) When (Q)
Total
 
 
2
1
10
11
53
27
5
3
2
1
56547
 
Group 1
P2
Something
 
 
 
5
20
6
 
 
 
 
16915
Q4-15
Group 2
P2
Something
 
 
 
 
8
 
 
 
 
 
3840
Q4-15
Group 3
P2
Something
 
 
 
 
4
 
 
 
 
 
1920
Q4-15
Group 4
P2
Something
2
 
4
4
 
 
2
1
2
 
19230
Q4-15
Group 5
P2
Something
 
1
2
2
 
 
1
1
 
1
14642
Q4-15

Total is 121181

The problems I see

Is that like in Item13570

  • there are two edit buttons per table.
  • When you add a row the plugin ignores the footer row info from the TABLE tag and adds the new row below the footer row. it seems you can move it up afterwards but that goofs the display of the CALCs until you have refreshed the page.

-- KennethLavrsen - 28 Jul 2015

i don't see either of the reported problems (or any other problems for that matter) in latest ERP. Leaving for feedback in case I missed something.

-- Main.CrawfordCurrie - 17 Sep 2015 - 06:35

I cannot verify this is closed before you fix the obvious problem that jumps right into your eyes just by looking at TestCases/TestCaseEditTableMixedTagOrder (on your pseudoinstalled developer installation. I guess I have to open bug items on everything I see then. I had hoped you would run those test cases yourself.

-- KennethLavrsen - 17 Sep 2015

How about the first column? The one that gets added with the pencil. Don't you see that it takes the width of the customer column? (not here on f.o because it is not updated)

-- KennethLavrsen - 17 Sep 2015

I have now provided feedback for 6 hours. I have walked through all the TestCases web tests I created years ago. And each and every thing I saw has been raised as bug items. Most of them urgent. And I think 1 normal and 1 low priority. None of these bugs were difficult to reproduce because the test cases are already there.

-- KennethLavrsen - 17 Sep 2015

The issues in this report are reported in individual tasks. No action on this task (the others are all live)

-- Main.CrawfordCurrie - 28 Sep 2015 - 07:43
 

ItemTemplate edit

Summary EditRowPlugin and EditTablePlugin Test case from hell
ReportedBy KennethLavrsen
Codebase
SVN Range
AppliesTo Extension
Component EditRowPlugin
Priority Urgent
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease patch
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r6 - 28 Sep 2015, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy