You are here: Foswiki>Tasks Web>Item13725 (10 Oct 2015, GeorgeClark)Edit Attach

Item13725: SmiliesPlugin can be made a little easier to upgrade with simple css change.

pencil
Priority: Low
Current State: Closed
Released In: 2.0.2
Target Release: patch
Applies To: Extension
Component: SmiliesPlugin
Branches: master
Reported By: KennethLavrsen
Waiting For:
Last Change By: GeorgeClark
The new SmiliesPlugin has en increased number of icons and they look better and are animated.

Cool enhancement

For upgraders that has a Set SMILIESPLUGIN_TOPIC = MyOwnSmilies they will have copies of all the old 15x15 icons + all their custom icons.

And both the old and the custom icons get scaled up because of the new smiles.css setting height:1.5em;

This means that an upgrader will either have to put up with blury icons or spend time trying to merge custom icons with the new nicer icons. I am sure he will want to do that eventually but it would be nice not to have this on the long list of upgrade issues.

I tried to remove the the height:1.5em; from the smiles.css.

I could not see any visible effects on the new icons. They look just as great.

But on the old icons - the 15x15 are shown at the original size sharp and not blury.

MichaelDaum - you are the CSS expert and also know the effect on your own NatSkin.

Can the height:1.5em; be removed from the smilies.css?

It would be a small thing that makes upgrading just a little bit easier.

-- KennethLavrsen - 17 Sep 2015

Michael, although low priority, this does seem rather innocuous. I'd like to get it into 2.0.2 if it makes sense. Thanks

-- GeorgeClark - 17 Sep 2015

You are right. Go ahead and check in your proposed fix.

-- MichaelDaum - 17 Sep 2015
 

ItemTemplate edit

Summary SmiliesPlugin can be made a little easier to upgrade with simple css change.
ReportedBy KennethLavrsen
Codebase 2.0.1
SVN Range
AppliesTo Extension
Component SmiliesPlugin
Priority Low
CurrentState Closed
WaitingFor
Checkins distro:ef44d8fdc787
TargetRelease patch
ReleasedIn 2.0.2
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:ef44d8fdc787
ItemBranchCheckins
Release01x01Checkins
Topic revision: r6 - 10 Oct 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy