Item14118: TRACE mode turned on

pencil
Priority: Enhancement
Current State: Confirmed
Released In: n/a
Target Release:
Applies To: Extension
Component: CalDAVPlugin
Branches: master
Reported By: ChrisCauser
Waiting For:
Last Change By: GeorgeClark
TRACE appears to be turned on, which is giving weird output:

https://github.com/foswiki/CalDAVPlugin/blob/master/lib/Foswiki/Plugins/CalDAVPlugin/Core.pm#L23

I am happy to create a pull request for it. While browsing the source, it also appears there are a few things that can be done to clean up the code a little:

  • Needless dependency on Cal::DAV - Since all we care about is an ics valid file, you can use any HTTP client and Data::ICal (which is a dependency on Cal::DAV.
  • If you remove the dependency on Cal::DAV, you can then use files on the Foswiki server
  • If the URL returns 200, but an invalid ics file, the page containing CALENDAR dies with "Can't locate object method "entries" via package "Class::ReturnValue"

Since I've patched the code locally for the TRACE => 1, I'm now a happy user, and if you want me to file separate reports for the bullet-points above, I can do.

Pull request: https://github.com/foswiki/CalDAVPlugin/pull/1

-- ChrisCauser - 22 Jul 2016

Thanks for the patch! It appears that MichaelDaum merged your patch on July 22nd, but a new release has not yet been built.

Setting this to Confirmed.

-- GeorgeClark - 25 Sep 2016

-- GeorgeClark - 25 Sep 2016
 
Topic revision: r2 - 25 Sep 2016, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy