You are here: Foswiki>Tasks Web>Item14583 (05 Jan 2018, GeorgeClark)Edit Attach

Item14583: Circular parentality of topics is allowed and breaks some functionalities

Priority: Enhancement
Current State: Proposal Required
Released In: n/a
Target Release: n/a
Applies To: Engine
Component: FoswikiMeta
Reported By: WillLe
Waiting For:
Last Change By: GeorgeClark
I've just tested topics' parental hierarchy and found that circular parental relation can be set via "More topic actions" > "Set new topic parent."

This circular relation should be detected and rejected, or else it will break many functionalities, eg. Hierarchical Navigation, "Update links" in "Rename or move topic", etc.

-- WillLe - 17 Dec 2017

Marking this as an enhancement request. This will need a developer.

-- GeorgeClark - 05 Jan 2018

The current implementation is a simple $topicObject->put( with no validation done beyond confirming that it's a legal topic name. The validation is done in Foswiki::UI::Save. This should be considered for refactor, adding a setParent method to Foswiki::Meta that does more complete validation. This really needs a feature proposal.

-- GeorgeClark - 05 Jan 2018

ItemTemplate edit

Summary Circular parentality of topics is allowed and breaks some functionalities
ReportedBy WillLe
Codebase 2.1.4, trunk
SVN Range
AppliesTo Engine
Component FoswikiMeta
Priority Enhancement
CurrentState Proposal Required
TargetRelease n/a
ReleasedIn n/a
Topic revision: r2 - 05 Jan 2018, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy