You are here: Foswiki>Tasks Web>Item14788 (12 Feb 2019, MichaelDaum)Edit Attach

Item14788: NatSkin: missing icon in icon template

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: NatSkin
Branches:
Reported By: GinoNaumann
Waiting For:
Last Change By: MichaelDaum
We have NatSkin 5.01 and Foswiki 2.1.6 in action.

I noticed, that the icon NEXT_ICON is missing. By the way, the i class of LAST_ICON is wrong. You can't use this icon.

My git commit fixed the issue(s).


commit a0237de723361031a99c3b6420f04160135c7a2f
Author: Gino Naumann <gino.naumann@fu-berlin.de>
Date:   Wed Nov 14 13:00:31 2018 +0100

    Fix Icon problems
    
    Added NEXT_ICON
    Modified LAST_ICON

diff --git a/templates/icons.ma.nat.tmpl b/templates/icons.ma.nat.tmpl
index afa373a0..8e912023 100644
--- a/templates/icons.ma.nat.tmpl
+++ b/templates/icons.ma.nat.tmpl
@@ -18,7 +18,7 @@
 %TMPL:DEF{"FIRST_ICON_RESTRICTED"}%<i class='ma ma-first-page'></i>%TMPL:END%
 %TMPL:DEF{"HARVEST_ICON"}%<i class='ma ma-file-download'></i>%TMPL:END%
 %TMPL:DEF{"HISTORY_ICON"}%<i class='ma ma-change-history'></i>%TMPL:END%
-%TMPL:DEF{"LAST_ICON"}%<i class='ma ma-last'></i>%TMPL:END%
+%TMPL:DEF{"LAST_ICON"}%<i class='ma ma-last-page'></i>%TMPL:END%
 %TMPL:DEF{"LAST_ICON_RESTRICTED"}%<i class='ma ma-last-page'></i>%TMPL:END%
 %TMPL:DEF{"LIKE_ICON"}%<i class='ma ma-thumb-up'></i>%TMPL:END%
 %TMPL:DEF{"LOG_IN_ICON"}%<i class='ma ma-vpn-key'></i>%TMPL:END%
@@ -28,6 +28,7 @@
 %TMPL:DEF{"MOVE_ICON"}%%JQICON{"fa-arrows"}%%TMPL:END%
 %TMPL:DEF{"_NEW_ICON"}%<i class='ma ma-add'></i>%TMPL:END%
 %TMPL:DEF{"NEW_ICON"}%%JQICON{"fa-plus"}%%TMPL:END%
+%TMPL:DEF{"NEXT_ICON"}%<i class='ma ma-chevron-right'></i>%TMPL:END%
 %TMPL:DEF{"PDF_ICON"}%<i class='ma ma-picture-as-pdf'></i>%TMPL:END%
 %TMPL:DEF{"PREV_ICON"}%<i class='ma ma-chevron-left'></i>%TMPL:END%
 %TMPL:DEF{"PREV_ICON_RESTRICTED"}%<i class='ma ma-chevron-left'></i>%TMPL:END%

Could you fix these issuses in your source code?

-- GinoNaumann - 19 Nov 2018

Should be fine in latest NatSkin version now. Please reopen when the problem still persists.

-- MichaelDaum - 12 Feb 2019
 
Topic revision: r2 - 12 Feb 2019, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy