Item14901: Add support for XML and CERT data types in configure pages
Current State: Waiting for Release
Released In: 2.1.7
Target Release: patch
Copied from Question1978
I am looking at some improvements to the configuration of the SamlLoginContrib
. It currently requires you to put the certs and the metadata.xml on the server in a location to be read in as a file. I would like to allow adding those items to the LocalSite
I propose adding:
The only field present currently that is big enough is Types.PERL which tries to evaluate as valid perl.
I did a PoC
just making the validation pass with:
av = eval(1); // FIXME: TIM
bv = eval(1); // FIXME: TIM
and the resulting fields will work for me.
I don't mind doing the work to validate that the xml is valid uncommented xml and that the cert is a valid certificate but I want to check whether this would be considered for inclusion first. There are a least a few plugins/contribs that would be improved by a larger field for certificates (LDAP and SMTP)
- 15 Apr 2020[[/pub/Tasks/Item14901/]]
- 15 Apr 2020
Okay, so this is
Only things remaining are:
- add an entry to the change log of System.ConfigurePlugin
- update VERSION and RELEASE in Foswiki::Plugins::ConfigurePlugin
- update all copyright years as mentioned in the sources
- cherry pick those changes to/from both active branches in the repo
Then flag this bug item waiting for release so that mentioning it in the release notes of 2.1.7 won't fall thru the crax.
- 17 Apr 2020
I will do that later today or this weekend
- 17 Apr 2020
Merger and think I did everything.
- 19 Apr 2020