Item15136: Foswiki::Meta::save() sets topic and web too late when copying a topic

A topic is copied using this code:

my $meta = Foswiki::Meta->load($session, $sourceWeb, $sourceTopic);
$meta->save(
   web => $targetWeb,
   topic => $targetTopic
);

When saving the new object is created at the target location. However, this is done in Foswiki::Meta::saveAs(). This is too late as any beforeSaveHandler will still be using the $sourceWeb.$sourceTopic. What happens is:

1. Foswiki::Meta::load(): new meta is created based on the source
2. Foswiki::Meta::save(): is called with target parameters (see above code)
3. any beforeSaveHandler is dispatched using the source object
4. afterwards Foswiki::Meta::saveAs() is called
5. the meta object's new target location is set
6. the meta object is delegated to the store layer
7. any afterSaveHandler is displatched using the new target object

The error happens in (3): the new target location should already be set there: the object about to be saved is not the source but the target one.

-- MichaelDaum - 24 May 2022

Commenting is disabled while not logged in