You are here: Foswiki>Tasks Web>Item1831 (14 Sep 2009, MichaelDaum)Edit Attach

Item1831: Undocumented dependence of ImagePlugin

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: ImagePlugin
Branches:
Reported By: ItaloValcy
Waiting For:
Last Change By: MichaelDaum
Hi,

Is there any reasons for ImagePlugin's dependence of LWP::UserAgent? So, I saw in plugin documentation the following text:

"If you specify a remote url using http://... the image is downloaded (using CPAN:LWP::Simple) into a local cache and then processed as usual. "

However, this isn't in the plugin dependencies field. I got the following error running this plugin without install LWP::UserAgent perl module:

==> /var/lib/foswiki/data/warn.log <==
| 2009-07-16T23:06:27Z warning | Can't locate LWP/UserAgent.pm in @INC (@INC contains: /var/lib/foswiki/lib /etc/foswiki . /etc/perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl) at /var/lib/foswiki/lib/Foswiki/Plugins/ImagePlugin/Core.pm line 199.
 at /var/lib/foswiki/lib/Foswiki/Plugins/ImagePlugin/Core.pm line 199
   Foswiki::Plugins::ImagePlugin::Core::handleIMAGE('Foswiki::Plugins::ImagePlugin::Core=HASH(0x2f30490)', 'HASH(0x2d835f0)', 'WebHome', 'Polifonica') called at /var/lib/foswiki/lib/Foswiki/Plugins/ImagePlugin.pm line 134
   Foswiki::Plugins::ImagePlugin::renderExternalLink('Foswiki::Render=HASH(0x27df538)', undef) called at /var/lib/foswiki/lib/Foswiki/Render.pm line 1172
   Foswiki::Render::getRenderedVersion('Foswiki::Render=HASH(0x27df538)', '---+!! Aglomera\x{e7}\x{e3}o Polif\x{f4}nica\x{a}\x{a}*Novas Produ\x{e7}\x{f5}es:*\x{a}\x{a}   * [[Pri...', 'Polifonica', 'WebHome') called at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 389
   Foswiki::UI::View::_prepare('---+!! Aglomera\x{e7}\x{e3}o Polif\x{f4}nica\x{a}\x{a}*Novas Produ\x{e7}\x{f5}es:*\x{a}\x{a}   * [[Pri...', 'Foswiki=HASH(0x14cfe68)', 'Polifonica', 'WebHome', 'Foswiki::Meta=HASH(0x29623c0)', 0) called at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 368
   Foswiki::UI::View::view('Foswiki=HASH(0x14cfe68)') called at /var/lib/foswiki/lib/Foswiki/UI.pm line 299
   Foswiki::UI::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0x15890c8)', 'HASH(0x296e860)') called at /var/lib/foswiki/lib/Foswiki/UI.pm line 381
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x1a8fb20)', 'CODE(0x1a8f4c0)', 'view', 1) called at /var/lib/foswiki/lib/Foswiki/UI.pm line 270
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x1a8fb20)') called at /var/lib/foswiki/lib/Foswiki/Engine/CGI.pm line 26
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x18c62b8)') called at /usr/lib/cgi-bin/foswiki/view line 45.
 |

Another thing: the suport field (an URL) in plugin info form is also incorrect.


Quick fixed the DEP file in trunk, but did not create a new release of the extension.

-- OliverKrueger - 18 Jul 2009


Thanks Oliver. Please, could you change the Support field in plugin info form? I think that the following is sufficient:
Index: data/System/ImagePlugin.txt
===================================================================
--- data/System/ImagePlugin.txt   (revisão 4505)
+++ data/System/ImagePlugin.txt   (cópia de trabalho)
@@ -270,7 +270,7 @@
 |  Other Dependencies: |  |
 |  Perl Version: | 5.8 |
 |  Home: | Foswiki:Extensions/%TOPIC% |
-|  Support: | Foswiki:Extensions/%TOPIC% |
+|  Support: | Foswiki:Support/%TOPIC% |
 
 
 %META:FILEATTACHMENT{name="WestminstpalaceSample.png" attr="h" autoattached="1" comment="" date="1185796830" path="WestminstpalaceSample.png" size="107728" user="ProjectContributor" version="1"}%

-- ItaloValcy - 18 Jul 2009

The next release of the foswiki.org website will hopefully combine the home of an extension with support and bugs under a single url.

-- OliverKrueger - 19 Jul 2009


Ok, I didn't know about that. Thanks, Oliver.

-- ItaloValcy - 19 Jul 2009

Fixed DEPs

-- MichaelDaum - 14 Sep 2009

ItemTemplate edit

Summary Undocumented dependence of ImagePlugin
ReportedBy ItaloValcy
Codebase 1.0.6
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component ImagePlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins ImagePlugin:3a6325f2102d ImagePlugin:d0789d26e97c ImagePlugin:a7eac68cecbe
TargetRelease n/a
ReleasedIn
Topic revision: r9 - 14 Sep 2009, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy