You are here: Foswiki>Tasks Web>Item2054 (20 Sep 2009, PaulHarvey)Edit Attach

Item2054: jQuery::TabPane causes NatSkin to sometimes have a blank editor window

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: JQueryPlugin
Branches:
Reported By: PaulHarvey
Waiting For: Main.PaulHarvey
Last Change By: PaulHarvey
I've been getting complaints on our test FW1.06 server that users are sometimes presented with a blank edit window. All they see is the (save, save & continue, ... cancel buttons).

We're running FW 1.0.6 with trunk NatSkin(Plugin), JQueryPlugin, NatEditPlugin.

Attached screenshot.

I have observed that this is due to the tab pane holding the editor(s) from failing to be made visible.

This seems to stem from faulty initialisation via the foswiki.jquery.tabpane array, which sometimes only holds two out of the three tabpanes present in the NatSkin edit template.

Haven't had time yet to discover why this is the case.

Perhaps we should mandate usage of JSLint.

  • natskin_blank_editor.png:
    natskin blank editor.png

-- PaulHarvey - 13 Sep 2009

Yes seen them myself. I've reworked the init code for tabpanes, toggles and buttons again by going away from putting init params into <meta> tags in the head. They are now metadata inside the class attribute and extracted via jquery.metadata plugin. This has the other side effect that these can also init'ed when the gui has been loaded via ajax ... a situation where these extra elements won't be able to add &llt;meta> tags anymore...

-- MichaelDaum

I see. I've updated JQueryPlugin again, I am only updating it when I see changes happen on svn, but I must have missed your last commit which takes us back to in-line <script>, which I suppose will fix the problem for now.

Can you attach your new JQuery code here if you don't want to commit it yet? I can help with testing, etc.

-- PaulHarvey - 14 Sep 2009

Thanx in advance. Will checkin to SVN ASAP smile

-- MichaelDaum - 14 Sep 2009

Please try again with v2.04

-- MichaelDaum - 14 Sep 2009

Testing it with 5 users over the next few days.

-- PaulHarvey - 15 Sep 2009

It seems this issue is fixed, thankyou. Closing.

-- PaulHarvey - 20 Sep 2009

ItemTemplate edit

Summary jQuery::TabPane causes NatSkin to sometimes have a blank editor window
ReportedBy PaulHarvey
Codebase 1.0.6, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component JQueryPlugin
Priority Normal
CurrentState Closed
WaitingFor PaulHarvey
Checkins distro:e0bfead19e0c
TargetRelease n/a
ReleasedIn
I Attachment Action Size Date Who Comment
natskin_blank_editor.pngpng natskin_blank_editor.png manage 57 K 13 Sep 2009 - 13:34 PaulHarvey  
Topic revision: r8 - 20 Sep 2009, PaulHarvey
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy