Item2659: Two small issues with natskin attach templates
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: NatSkin
Branches:
I have two small issues with the attachtables.nat template in natskin. The solution I have found is very simple, so I file a report of this hoping that a fix can be part of future releases of natskin.
1. In the attachment version table, the are only one row. I have found that the TMPL:END for the TMPL:DEF{ATTACH:versions:row} need to be placed differently. Placing it a new line makes the table become a table again. Like:
%TMPL:DEF{ATTACH:versions:row}% | %A_ICON% | <a href="%A_URL%">%A_FILE%</a><div class="natAttachmentComment"><noautolink>%A_COMMENT%</noautolink></div> | %A_REV% | %A_SIZE% | <nobr>%A_DATE%</nobr> | %A_USER% |
%TMPL:END%
2. Missing a "manage revision" link for attachments in natskin: In the TMPL:DEF{ATTACH:files:row:A} below the "Edit properties of this attachment"-href there should be a manage revision link, similar as in the attachtable.pattern.tml. I have included the following making the version history available again.
<a href="/bin/attach/Tasks/Item2659?filename=\%ENCODE{%A_FILE%}\%;revInfo=1" title='Manage revisions' rel='nofollow'><img src="/pub/System/FamFamFamMiniIcons/icon_history.gif" border="0" width="16" height="16" /></a>
(without the \ before %)
Best regards
--
AtleBriskemyr - 19 Jan 2010
Should be fixed in v3.96
--
MichaelDaum - 12 Feb 2010