Item397: Nat Skin javascript error on ie6 png fix

Nat Skin javascript error:

/* ie6 png fix */
* html img,
* html .jqButtonIcon,
* html .natUserAction,
* html .natTopicAction {
  behavior:url(http://foswiki.org/pub/TWiki/NatSkin/iepngfix.htc);
}

I assume this is IE only code, and should be moved to a template, like:

<!--[if IE]><style type="text/css" media="screen">
code here...
</style>
<![endif]-->

---

Seems like this is applied. Should it be added to NatSkinPlugin?

-- KwangErnLiew - 11 Dec 2008

It might be fixed in the skin, but is still at foswiki.org. Changing "Applies to" to website.

• ArthurClemens - 12 Dec 2008

What I meant was, it is changed on the website, but may not be in the NatSkinPlugin. I see no problems with IE6 for PNG. It shows the same as I see in FF.

Can you please double check?

• KwangErnLiew - 13 Dec 2008

It hs not changed on the website. Go to a page, view source, and there is behavior.

• ArthurClemens - 13 Dec 2008

Oops, I misunderstood the report heh My bad Arthur.

I shall attempt to look at this bug report...

• KwangErnLiew - 13 Dec 2008

If some can't save on foswiki anymore due to this bug as it happened to Arthur, there's a small work around till a fix is available...

It requires the Mozilla extension Firebug or an equivalent for IE. If installed open the console and paste submitEditForm('save', 'save') this should allow you to save

• CarloSchulz - 18 Dec 2008

You call that a work around?

How about changing to Pattern Skin? THAT is a work around that will work.

How many severe bugs does this community have to endure? And for how long?

This is waiting for Michael Daum. He has announced that he will not be participating on the project until some time in the new year.

Are we going to put up with this bug for another month?

• KennethLavrsen - 18 Dec 2008

As the behavior property is non-standard, all browsers other than IE will ignore it. On Firefox, a console warning is produced indicating that the property is unknown and being dropped. The behavior file is not read in and should not be producing an error. The error must be coming from somewhere else. -- IsaacLin - 18 Dec 2008

Correct, this is not the blocking error. This one is:

Error: self._setBlockingState is not a function
Source File: http://foswiki.org/pub/TWiki/TWikiJavascripts/twiki_edit.js
Line: 16

This code is not part of the standard TWiki distribution and must have been added for this site.

Strange. This is not in twiki_edit either. I get a suspicion this is happening because of a mixture of pattern skin with natskin because of the caching mechanism.

-- ArthurClemens - 18 Dec 2008

I performed the following steps to reproduce the issue (Firefox 2.0.0.18 on Windows Vista):

• Set SKIN to pattern in my user topic.
• Visited Support.WebHome; page had the appearance of NatSkin.
• Selected Edit. Still looks like NatSkin and its editor.
• Made a change and selected Save. Was returned to the same Edit page, but the contents were reverted to its original value (call it version A).
• Made the changes again and selected Save again. Changes were saved (call it version B).

At Arthur's direction, I then went to http://foswiki.org/bin/pcad and bypassed the cache for an hour.

• Visited Support.WebHome.
• Selected Edit.
• Made a change and selected Save. Was returned to the same Edit page, but the contents were reverted to version A.
• Made the changes again and selected Save again. Changes were saved (call it version C).

I did not see any Javascript errors in the message console.

Editing this topic (i.e. Item397) appeared to work fine; the page has the appearance of PatternSkin, as expected. However, when I select "Preview", I get an error message: Error: enableTWikiMandatoryChecks is not defined. This is being triggered by the onclick event on the Preview button. I did not notice any ill effects because of this error.

While editing my user topic to remove the SKIN setting, the following occurred:

• Visited my user topic. It had the appearance of PatternSkin.
• Selected Edit on my user topic. The Edit page had the appearance of NatSkin.
• Made changes and selected Preview. Was returned to the same Edit page, but the contents were reverted back to version A again (i.e. not the value before the edit, but the version before that).
• Made the changes again and selected Preview again. Was directed to http://foswiki.org/bin/save/Main/IsaacLin and saw a blank page. The page skeleton is there, but there is nothing in the <div class="patternTopic"> element.

I then went back to my user topic and performed the same steps as above when editing Support.WebHome — instead of selecting Preview, I selected Save, made the changes again, and selected Save again. The behaviour was the same as with Support.WebHome.

-- IsaacLin - 18 Dec 2008

The IE PNG fix did not cause the javascript error. It was caused due to an error in JQueryPlugin's BUTTON impl. This has been fixed. The IE PNG fix did not work because for some reason there was a wrong blank.gif in NatSkin. This has been fixed so that it takes effect again. There's no need for conditional css for IE as the used css hack already addresses IE6 only.

-- MichaelDaum - 08 Jan 2009