You are here: Foswiki>Tasks Web>Item463 (22 Apr 2009, KennethLavrsen)Edit Attach

Item463: %BR% needs a trailing space otherwise it breaks at least one ETP test

pencil
Priority: Normal
Current State: Closed
Released In: 1.0.4
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: Foswiki:Main.OlivierRaginel
Waiting For:
Last Change By: KennethLavrsen
See distro:c07a27210ccd

This final space breaks the TML rendering in EditTablePlugin. according to the unit test.

It's very odd that a single space breaks down the all thing, thus this requires immediate review, which is why this bug is set to Urgent, as suggested by Foswiki:Main.SvenDowideit

-- OlivierRaginel - 14 Dec 2008

As this only broke 1 unit test, either the tests are no good, or only ETP is vulnerable and ETP should be fixed to render %BR% as %BR%[space].

-- ArthurClemens - 14 Dec 2008

I would suspect this means there are not enough tests - for eg, the effects of %BR%NotAnAutoLink


NotAnAutoLink with a sapce

vs


NotAnAutoLink without a space

Just so people remember the history

The reason for the space needed is that when you edit multi line fields in ETP the ETP separates each line by
and this causes much trouble when you write URLs and Wikiwords in such text fields. They do not render unless you remember a dummy space. Setting %BR = "<br /> " (including the space) was a quick fix for this.

If someone makes a fix you better make sure you spend at least one hour on testing with actual data because you declare it fixed.

I am lowering this to normal as normally you do not edit DefaultPreferences and delete the space.

And I find it dangerous to fix this. If you do anyway please ping me so I can test too with real topics from the office. This has caused trouble before.

-- KennethLavrsen - 16 Dec 2008

This was fixed in another report by improving ETP

-- KennethLavrsen - 22 Apr 2009

ItemTemplate edit

Summary %BR% needs a trailing space otherwise it breaks at least one ETP test
ReportedBy Foswiki:Main.OlivierRaginel
Codebase trunk
SVN Range SVN 1335: Foswiki-0.9.0, Sat, 13 Dec 2008, build 1322
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.0.4
Topic revision: r5 - 22 Apr 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy