Item5250: ! gets removed from in front of words

pencil
Priority: Enhancement
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: EditChapterPlugin
Branches:
Reported By: TWiki:Main.ScottHinchley
Waiting For:
Last Change By: MichaelDaum
When using EditChapterPlugin if you edit a section that use !WikiWord instead of WikiWord to prevent WikiWords from becoming links, the ! will be removed, causing the item to become a Link.

It seems to work ok if the ! is at the start of a line, but after a * or in the middle of sentence the ! is removed from the whole Topic not just the section being edited.

-- TWiki:Main/ScottHinchley - 15 Jan 2008

Hm. Can't reproduce. Could you please create a testcase what exactly you entered in a
<verbatim>
verbatim test case
</verbatim>

Thanks.

-- TWiki:Main.MichaelDaum - 14 Feb 2008

This is some text in line !ButSome !WikiWords have ! instead of <nop>
Now if this is in a section and you edit with !EditChapterPlugin
The ! will go away turning it back into a Link, most likely with a ? link to create a new page, since it was not meant to be a link (reason for !).

!ButStarting a line with ! seems to be ok.  Let me know if you still do not see it.

I am running This site is running TWiki version TWiki-4.1.2, Sat, 03 Mar 2007, build 13046, Plugin API version 1.11
EditChapterPlugin (1.0, $Rev: 16134 (03 Jan 2008) $): An easy sectional edit facility

-- TWiki:Main.ScottHinchley - 15 Feb 2008

Argh this really only happens on TWiki engines before 4.2. TWiki-4.2 protects textareas in TWiki::Render::getnRenderedVersion(). This feature is not present in TWiki-4.1.2. I will add a workaround to surround the result of EXTRACTCHAPTER with <literal>...</literal> to persuade it not to touch the text inside textareas.

-- MichaelDaum - 13 Mar 2008

Scott, can you still reproduce it with the latest version 1.14?

-- TWiki:Main.MichaelDaum - 29 Apr 2008

Just saw your message, and updated to 1.14 (with everything else the same), and yes it is still still broke. But looking at your change notices you pulled the literal hack out, guess you were hoping some other part fixed it... ;-). Item5251 also still breaks.

The other strange thin I saw was initially I was not getting the icons after the headers to edit, until I did an actual edit (don't think it matter which page), then things started to allow me to edit sections, just a strange thing to note...

Let me know if there is more you want me to try..

-- TWiki:Main.ScottHinchley - 06 May 2008

The "literal" hack did not work on my install, although I might see what makes this fail on a 4.1.2: textareas are explicitly protected in 4.2 from being touched by the renderer. I think best would be to backport that fix to 4.1.2, shipping it as a patch together with this plugin...

-- TWiki:Main.MichaelDaum - 06 May 2008

ok let me know, will grab the patch and try it on my system.

-- TWiki:Main.ScottHinchley - 07 May 2008

Fixed on current version.

-- MichaelDaum - 17 Apr 2009

ItemTemplate edit

Summary ! gets removed from in front of words
ReportedBy TWiki:Main.ScottHinchley
Codebase
SVN Range TWiki-4.3.0, Sun, 30 Dec 2007, build 16120
AppliesTo Extension
Component EditChapterPlugin
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn
Topic revision: r9 - 17 Apr 2009, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy