Item5560: FormPlugin: calendar button invisible if there are no twisties on the same page

pencil
Priority: Urgent
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: FormPlugin
Branches:
Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum
This plugin surrounds the calendar button with a span of this kind:
<span class="twikiMakeVisible"
...
</span>

The twikiMakeVisibleXXX classes are hidden by default CSS and only exposed if there is a TWISTY on the same page, which would then trigger the twikiMakeVisibleXXX tags to be uncovered. Outchie.

The solution for now is to remove this extra span:
--- lib/TWiki/Plugins/FormPlugin.pm     (revision 16706)
+++ lib/TWiki/Plugins/FormPlugin.pm     (working copy)
@@ -1383,7 +1383,6 @@
               || $TWiki::cfg{JSCalendarContrib}{format}
               || "%e %B %Y";

-            $text .= ' <span class="twikiMakeVisible">';
             my $control = CGI::image_button(
                 -class   => 'editTableCalendarButton',
                 -name    => 'calendar',
@@ -1398,7 +1397,6 @@
             #fix generated html
             $control =~ s/MIDDLE/middle/go;
             $text .= $control;
-            $text .= '</span>';
         }
     };
     return $text;

Arthur, can you please comment on the use of the twikiMakeVisibleXXX and similar CSS classes, i.e. if there are no TWISTIES on the same page.

-- MichaelDaum - 22 Apr 2008

twikiMakeVisible CSS classes are meant to not show interface parts that rely on javascript (regardless of a TWISTY tag). But since we also have a guideline to not make default skin rely on javascript, these CSS classes are not in default skin, only in pattern skin.

In css.pattern.tmpl I have this:
%TMPL:DEF{"javascriptaffectedstyle"}%<script type="text/javascript" src="%PUBURLPATH%/%SYSTEMWEB%/TWikiJavascripts/twikiStyles.js"></script>%TMPL:END%

-- ArthurClemens - 02 May 2008

Hm, does only work on 4.2. Can't we dismiss this css-js interaction?

-- MichaelDaum - 06 May 2008

Works on Foswiki since it is > TWiki 4.2.

-- ArthurClemens - 22 Jan 2009

ItemTemplate edit

Summary FormPlugin: calendar button invisible if there are no twisties on the same page
ReportedBy MichaelDaum
Codebase
SVN Range TWiki-5.0.0, Tue, 15 Apr 2008, build 16676
AppliesTo Extension
Component FormPlugin
Priority Urgent
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
Topic revision: r5 - 09 Nov 2010, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy