Item8112: Issues with conversion to Foswiki

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release:
Applies To: Extension
Component: ImageGalleryPlugin
Branches:
Reported By: Foswiki:Main.GeorgeClark
Waiting For:
Last Change By: MichaelDaum
I've run into a couple of issues with ImageGalleryPlugin when trying to migrate a T.O 4.1.2 installation over to Foswiki.

Example
Error: no images found
0 images found. 

  • The server logs the following errors for every page visited. It doesn't have to be a page containing any gallery. The path doesn't seem to be relocated to the TWiki web by the plugin. The actual attachments are in the TWiki directory, not System, since the plugin is still in the TWiki namespace.

File does not exist: /var/www/htdocs/pub/System/ImageGalleryPlugin, referer: http://mysite.org/System/imageGalleryPlugin

  • On pages containing galleries, the following messages are repeated in the server log:

 view: Use of uninitialized value in hash element at /var/www/htdocs/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm line 131.
 view: Use of uninitialized value in pattern match (m//) at /var/www/htdocs/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm line 134.
 view: Use of uninitialized value in pattern match (m//) at /var/www/htdocs/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm line 134.
 view: Use of uninitialized value in pattern match (m//) at /var/www/htdocs/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm line 134.
 view: Use of uninitialized value in concatenation (.) or string at /var/www/htdocs/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm line 147.
 view: Use of uninitialized value in concatenation (.) or string at /var/www/htdocs/lib/TWiki/Plugins/ImageGalleryPlugin/Core.pm line 147.

  • Storage of images in a pub directory that is not a web appears to be incompatible with viewfile for non-admin users. The logged in site administrator will work fine, but other users fail with "Foswiki detected an internal error - please check your Foswiki logs and webserver logs for more information. Can't use an undefined value as an ARRAY reference"

F
Can't use an undefined value as an ARRAY reference at /var/www/htdocs/lib/Foswiki/Prefs.pm line 235.
 at /var/www/htdocs/lib/Foswiki/Prefs.pm line 235
        Foswiki::Prefs::getPreferencesValue('Foswiki::Prefs=HASH(0x95371b4)', 'DENYWEBVIEW') called at /var/www/htdocs/lib/Foswiki/Prefs.pm line 333
        Foswiki::Prefs::getWebPreferencesValue('Foswiki::Prefs=HASH(0x90c91e0)', 'DENYWEBVIEW', '') called at /var/www/htdocs/lib/Foswiki/Access.pm line 176
        Foswiki::Access::checkAccessPermission('Foswiki::Access=HASH(0x94c5528)', 'VIEW', 'GeorgeClark', 'undef', 'undef', 'images', '') called at /var/www/htdocs/lib/Foswiki/Store.pm line 639
        Foswiki::Store::readAttachment('Foswiki::Store=HASH(0x8d1e514)', 'GeorgeClark', '', 'images', 'Myweb/PhotoGallery2008x01x10x0/1/thumb_DSC04500.JPG', 0) called at /var/www/htdocs/lib/Foswiki/UI/View.pm line 521
        Foswiki::UI::View::viewfile('Foswiki=HASH(0x891c648)') called at /var/www/htdocs/lib/Foswiki/UI.pm line 181
        Foswiki::UI::__ANON__() called at /var/www/htdocs/lib/CPAN/lib//Error.pm line 379
        eval {...} called at /var/www/htdocs/lib/CPAN/lib//Error.pm line 371
        Error::subs::try('CODE(0x8aa2a9c)', 'HASH(0x94cac90)') called at /var/www/htdocs/lib/Foswiki/UI.pm line 249
        Foswiki::UI::execute('Foswiki::Request=HASH(0x8937e34)', 'CODE(0x8d1daa0)', 'viewfile', 1) called at /var/www/htdocs/lib/Foswiki/UI.pm line 120
        Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x8937e34)') called at /var/www/htdocs/lib/Foswiki/Engine/CGI.pm line 26
        Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x8bbbf70)') called

-- GeorgeClark - 16 Apr 2009

Why does it use viewfile to serve images in pub/images? George, could you try again with the latest version, please?

-- MichaelDaum - 24 Apr 2009

Hi Michael, I did another migration of the same server using 1.0.5 and the latest plugins. All of the issues except for the last one appear to not be repeatable.

As far as the last one, the server was configured to rewrite pub access to viewfile for security. The viewfile changes adding a "images" layer between /pub and Web seems to break viewfile. I don't believe it is a problem with this plugin. Viewfile should probably be extended to permit a non-web root inside pub. Maybe a configuration parameter for non-Wiki managed attachments in "images" could support pub/images/Web/Topic. images needs to be removed for the authorization check.

I think that this can be closed

-- GeorgeClark - 29 Apr 2009

Hi George can you please try again with the ImageGalleryPlugin, release >=5.01

Thanks.

-- MichaelDaum - 03 Jul 2009

Seems to be fixed.

-- MichaelDaum - 21 Aug 2009

 

ItemTemplate edit

Summary Issues with conversion to Foswiki
ReportedBy Foswiki:Main.GeorgeClark
Codebase 1.0.4
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component ImageGalleryPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:8a48390fd60c ImageGalleryPlugin:36ea53f61ea0
ReleasedIn
Topic revision: r7 - 21 Aug 2009, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy