You are here: Foswiki>Tasks Web>Components>ImagePlugin>Item8200 (03 Jul 2009, MichaelDaum)Edit Attach

Item8200: Plugin strikes with Images containing 'clear' in the name.

Priority: Normal
Current State: Closed
Released In:
Target Release:

Applies To: Extension
Component: ImagePlugin
Branches:

Reported By: Foswiki:Main.AndreLichtsteiner
Waiting For:
Last Change By: MichaelDaum

ImagePlugin supports %IMAGE{"clear"}% as a feature in order the properly clear after a float. But the code in ImagePlugin/Core.pm recognizes 'clear' too generous, so an Image called 'Nuclear..' triggers a clear too!

Patch:

*** //lib/Foswiki/Plugins/ImagePlugin/Core.pm.patched   Thu Jul 02 16:07:41 2009
--- //lib/Foswiki/Plugins/ImagePlugin/Core.pm   Fri Apr 24 16:58:34 2009
***************
*** 130,132 ****
  
!   if($params->{_DEFAULT} =~ m/^(?:clr|clear)$/io ){ # SMELL: non-documented feature
      return $this->getTemplate('clear');
--- 130,132 ----
  
!   if($params->{_DEFAULT} =~ m/clr|clear/i ){ # SMELL: non-documented feature
      return $this->getTemplate('clear');

Regards

-- AndreLichtsteiner - 02 Jul 2009

Thanks Andre.

-- MichaelDaum - 03 Jul 2009

ItemTemplate edit

Summary	Plugin strikes with Images containing 'clear' in the name.
ReportedBy	Foswiki:Main.AndreLichtsteiner
Codebase
SVN Range	Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo	Extension
Component	ImagePlugin
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	ImagePlugin:4a7104e463da ImagePlugin:2e0bc61231c2
ReleasedIn