Item8215: (Duplicate of Item907) Conflicts with JSCalendarContrib

pencil
Priority: Low
Current State: No Action Required
Released In:
Target Release:
Applies To: Extension
Component: RenderFormPlugin
Branches:
Reported By: Foswiki:Main.PaulHarvey
Waiting For:
Last Change By: OliverKrueger
As per http://twiki.org/cgi-bin/view/Support/HowToIntegrateWeekAndMonthCalendar, we use JSCalendarContrib + CommentPlugin etc. to implement a collaborative calendar application in our wiki.

When RenderFormPlugin is enabled, it needlessly loads the JSCalendarContrib JavaScript a second time near the bottom of the rendered HTML.

This causes behaviour matching exactly the problems described at http://twiki.org/cgi-bin/view/Support/SID-00166

The culprit is in lib/Foswiki/Plugins/RenderFormPlugin.pm on line 48, which looks like this:
$_[0] =~ s/<\/body>/%INCLUDE{"%TWIKIWEB%\/JSCalendarContribInline"}%<\/body>/i if ($TWiki::Plugins::VERSION > 1.1) && ($_[0] !~ /JSCalendarContrib\twiki.js/);

I've commented it out as a temporary work-around.

The problem is that this checks only if the currently viewed topic text contains a fragment of what could be a JS load for JSCalendarContrib, but in our case the script load is injected during page rendering via a CommentPlugin user template.

-- PaulHarvey - 14 Jul 2009

Yikes. Duplicates Tasks.Item907. Somehow I didn't have the latest version of this extension.

-- PaulHarvey - 14 Jul 2009
 

ItemTemplate edit

Summary (Duplicate of Item907) Conflicts with JSCalendarContrib
ReportedBy Foswiki:Main.PaulHarvey
Codebase
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component RenderFormPlugin
Priority Low
CurrentState No Action Required
WaitingFor
Checkins
ReleasedIn
Topic revision: r2 - 15 Jul 2009, OliverKrueger
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy