Item8532: NatSkin should not depend on ImagePlugin
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: NatSkin
Branches:
We should add
ImagePlugin as a dep, seeing as users will get a red "Error: no such plugin imagetooltip" at the top of their screens when they upgrade/install from now on, unless they have
ImagePlugin.
P.S. Need to upload
ImagePlugin, MANIFEST is fixed (includes IMAGETOOLTIP.pm) in svn but extensions web still has the old release without that file.
--
PaulHarvey - 15 Feb 2010
No, it must degrade easily if
ImagePlugin is not installed. Quickfix:
--- javascript.nat.tmpl (revision 6336)
+++ javascript.nat.tmpl (working copy)
@@ -1,5 +1,6 @@
<!-- template: javascript.nat.tmpl -->
-%TMPL:DEF{"defaultjavascript"}%%JQREQUIRE{"superfish"}%%JQREQUIRE{"supersubs"}%%JQREQUIRE{"autocomplete"}%%JQREQUIRE{"imagetooltip"}%%TMPL:END%
+%TMPL:DEF{"defaultjavascript"}%%JQREQUIRE{"superfish"}%%JQREQUIRE{"supersubs"}%%JQREQUIRE{"autocomplete"}%%TMPL:P{context="ImagePluginEnabled" then="imagetooltip"}%%TMPL:END%
+%TMPL:DEF{"imagetooltip"}%%JQREQUIRE{"imagetooltip"}%%TMPL:END%
--
MichaelDaum - 16 Feb 2010
Fix released in 3.97
--
MichaelDaum - 17 Feb 2010
--
JohnWike - 04 May 2010