Item8557: MultiTopicSavePlugin - Counts multiple changes in same topic as multiple topics changes in message

pencil
Priority: Normal
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: MultiTopicSavePlugin
Branches:
Reported By: KennethLavrsen
Waiting For: Main.KennethLavrsen
Last Change By: KennethLavrsen
The message parameter that shows the number of changes messages counts wrong.

It is incremented each time a field is saved.

I had gotten the logic wrong so topics were saved for each field. I had meant not to do that by looping first topics in an outside loop and fields in an inside. But I managed to put the checking and saving in the inside loop.

I have done the following.

  • The checking is still in the inside loop because there is no point checking access if nothing has changed.
  • The inside loop "last" out first time we encounter a field that needs to be saved but access check fails.
  • If access check passed for first changed field there is no point checking again for the next changed field.
  • Not until all fields are looped through in the inner loop do we save the changed topic.
  • Counting happens in outer loop so we report the real number of saved topics.

-- KennethLavrsen - 17 Feb 2010

 

ItemTemplate edit

Summary MultiTopicSavePlugin - Counts multiple changes in same topic as multiple topics changes in message
ReportedBy KennethLavrsen
Codebase
SVN Range
AppliesTo Extension
Component MultiTopicSavePlugin
Priority Normal
CurrentState Closed
WaitingFor KennethLavrsen
Checkins MultiTopicSavePlugin:63082c1c1669
TargetRelease n/a
ReleasedIn
Topic revision: r4 - 18 Feb 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy