Item8636: the log changes have broken pseudo-install -a
Priority: Urgent
Current State: Closed
Released In:
Target Release: n/a
Applies To: Engine
Component:
Branches:
which is used for the nightly builds to create a minimally sufficient, and reproducably identical
LocalSite.cfg for the unit tests to run
the 'ass-humpt-ion' the
-a
option makes leaves the cfg with a line that simply says
$Foswiki::cfg{Log}{Action} = {
which is clearly broken.
marking urgent to Crawford so he sees it in case i don't get to fixing it first
--
SvenDowideit - 27 Feb 2010
? pseudo-install.pl doesn't
have a -a option ?
Oh, wait, you mean -A? Where did that come from?
grep? find? that must have been a late one for whoever wrote that code!
--
CrawfordCurrie - 01 Mar 2010
it was, silly me wrote the most nasty version i could in the hope someone else would see it and write something more appropriate - at the time I was actually thinking of a minimal set of options, rather than tossing all of them from Config.spec - but if it works, its good
unhappily, it doesn't work. reopening to fix
Running AccessControlTests
AccessControlTests::test_setInMETA
ERROR: Could not open logfile NOT SET/logs/error.log for write. Your admin should 'configure' now and fix the errors!
at /home/foswiki/NightlyBuild/trunk/core/test/unit/FoswikiTestCase.pm line 25
FoswikiTestCase::__ANON__('ERROR: Could not open logfile NOT SET/logs/error.log for writ...') called at /home/foswiki/NightlyBuild/trunk/core/lib/Foswiki/Logger/PlainFile.pm line 86
which means that
$Foswiki::cfg{Working}{Dir}
isn't being set.
actually, nor are any of the other paths - because.... they're commented out in the spec file to ensure they are set.
# $Foswiki::cfg{DefaultUrlHost} = 'http://your.domain.com';
# $Foswiki::cfg{PubDir} = '/home/httpd/foswiki/pub';
etc...
... and now, the trunk nightly builds actually run - fail on unit tests, but they do run.
Sadly, it looks like Crawford, and subsequently I, commited changes against Tasks.Item8638
--
SvenDowideit - 02 Mar 2010