Item8756: Configure goofs up default values of complex settings

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: configure
Branches:
Reported By: KennethLavrsen
Waiting For:
Last Change By: CrawfordCurrie
In trunk we now have a button that says default next to a setting that has a different current value than the default.

When you look at a plugin like TablePlugin its Config spec contains

$Foswiki::cfg{Plugins}{TablePlugin}{DefaultAttributes} = 'tableborder="1" valign="top" headercolor="#fff" headerbg="#687684" headerbgsorted="#345" databg="#fff,#edf4f9" databgsorted="#f1f7fc,#ddebf6" tablerules="rows" headerrules="cols"';

If you change this setting in configure to something slightly different and save (e.g. set tableborder="0") and return to configure you will see this default button/link next to the current value.

If you click it (and when you hoover over the default text) you see that configure thinks the default is

$Foswiki::cfg{Plugins}{TablePlugin}{DefaultAttributes} = 'tableborder="1" valign="top" headercolor="#fff" headerbg="D7684" headerbgsorted=""5" databg="#fff,#edf4f9" databgsorted="#f1f7fc,#ddebf6" tablerules="rows" headerrules="cols"';

so #687684 becomes D7684. And #345 becomes "5 (note the extra ")

The result is that tables are all wrong in colours.

The TablePlugin Config.spec looks completely OK.

This is a bug in configure.

-- KennethLavrsen - 23 Mar 2010

For some reason the JS in the client required a strange '#' based encoding that was unable to cope with an embedded #. I changed the code to use the standard URL encoding instead.

This was done slightly differently in 1.0.9 so it shouldn't exhibit the problem; thus closing this.

-- CrawfordCurrie - 24 Mar 2010

 

ItemTemplate edit

Summary Configure goofs up default values of complex settings
ReportedBy KennethLavrsen
Codebase trunk
SVN Range
AppliesTo Engine
Component configure
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:a747ff3c3209
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r2 - 24 Mar 2010, CrawfordCurrie
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy