You are here: Foswiki>Tasks Web>Item8870 (01 Nov 2011, GeorgeClark)Edit Attach

Item8870: Change default dependency type from perl to external so unspecified code is not loaded.

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: Configure
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
IF a dependency is missing the "Type" field, dependency.pm assumes that the module is type "perl" - implying a Foswiki/TWiki extension and will "eval" the module to determine if it is installed.

It would be safer to only issue the eval for dependencies explicitly marked cpan or perl, and assume external if the type is unknown.

It would probably also be preferable if BuildContrib warned that the dependency type was not set when building a release.

-- GeorgeClark - 09 Apr 2010

Also, it would be helpful if Dependency.pm reported the type of module it determined to not be installed. Adding module type to the module message.

-- GeorgeClark - 09 Apr 2010
 

ItemTemplate edit

Summary Change default dependency type from perl to external so unspecified code is not loaded.
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:b7417a8594d5 distro:6b96767bdab5
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r7 - 01 Nov 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy