Item9032: Inconsistent use of plugin setting

pencil
Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: NewUserPlugin
Branches:
Reported By: MartinKaufmann
Waiting For:
Last Change By: MichaelDaum
The plugin setting NEWUSERTEMPLATE is not checked if it's used in the form NEWUSERPLUGIN_NEWUSERTEMPLATE, e.g. in SitePreferences. I did the following adjustment to NewUserPlugin.pm which should be backwards compatible:

--- NewUserPlugin.pm.orig   2009-11-17 19:06:08.000000000 +0100
+++ NewUserPlugin.pm   2010-05-17 18:35:34.000000000 +0200
@@ -110,7 +110,9 @@
   my $systemWeb = $Foswiki::cfg{SystemWebName};
   my $usersWeb = $Foswiki::cfg{UsersWebName};
   my $newUserTemplate =
-    Foswiki::Func::getPreferencesValue('NEWUSERTEMPLATE') || 'NewUserTemplate';
+    Foswiki::Func::getPreferencesValue('NEWUSERPLUGIN_NEWUSERTEMPLATE') || 
+    Foswiki::Func::getPreferencesValue('NEWUSERTEMPLATE') ||
+    'NewUserTemplate';
   my $tmplTopic;
   my $tmplWeb;

-- MartinKaufmann - 17 May 2010

There's no such setting NEWUSERPLUGIN_NEWUSERTEMPLATE. Use NEWUSERTEMPLATE only.

-- MichaelDaum - 27 Feb 2013
 

ItemTemplate edit

Summary Inconsistent use of plugin setting
ReportedBy MartinKaufmann
Codebase 1.0.9
SVN Range
AppliesTo Extension
Component NewUserPlugin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r2 - 27 Feb 2013, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy